From owner-freebsd-ports-bugs@freebsd.org Sat Apr 29 19:37:28 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69AC4D54D19 for ; Sat, 29 Apr 2017 19:37:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 38F204E for ; Sat, 29 Apr 2017 19:37:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3TJbRGm063748 for ; Sat, 29 Apr 2017 19:37:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218956] www/nginx: XRID_HEADER option/module incompatible with nginx 1.12 Date: Sat, 29 Apr 2017 19:37:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: thomas@gibfest.dk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: osa@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Apr 2017 19:37:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218956 Bug ID: 218956 Summary: www/nginx: XRID_HEADER option/module incompatible with nginx 1.12 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: osa@FreeBSD.org Reporter: thomas@gibfest.dk Flags: maintainer-feedback?(osa@FreeBSD.org) Assignee: osa@FreeBSD.org Hello, nginx 1.12 grew its own $request_id variable [1] which means that the x-rid header module doesn't work anymore. When the module is compiled into 1.12 n= ginx fails to start with the following error: nginx: [emerg] the duplicate "request_id" variable in /usr/local/etc/nginx/nginx.conf:16 where line 16 is where the http {} section starts. This happens even with an empty http {} section. This can be a nasty surprise if upgrading nginx on a server and it refuses = to start no matter what you do. Since nginx now has it's own $request_id variable which does the same thing more or less, I suggest just removing the XRID_HEADER option and module. Servers which use $request_id in logs or other places will keep working, although the unique request id looks different: $request_id under nginx 1.10 with XRID_HEADER option: b14cb555-2c7a-11e7-9c03-0cc47a500f28 $request_id under nginx 1.12 without XRID_HEADER option: 416e2ca685b484a7c7218e24e3e98d4b Alternatively we would have to get upstream to change the name of the reque= st id variable in the 3rd party module at [2]. Once that is done we would have= to warn all users to rename the variable in their configs. Best regards /Thomas [1]: https://github.com/nginx/nginx/commit/f315b7a924fa2c0da69c21078c930391a424a= eef [2]: https://github.com/gabor/nginx-x-rid-header/blob/master/ngx_x_rid_header_mo= dule.c#L84 --=20 You are receiving this mail because: You are the assignee for the bug.=