Date: Thu, 29 Mar 2018 12:01:59 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Dimitry Andric <dim@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331686 - head Message-ID: <CANCZdfr0hKNvQCu26VEHFFyVypaJJ7vhUL6HmeRDcjaWtsNHtw@mail.gmail.com> In-Reply-To: <2963143.tibTdn2gMF@ralph.baldwin.cx> References: <201803281651.w2SGp59K069533@repo.freebsd.org> <3653AD2C-F427-4BE7-874C-FF3AF3BDA85D@FreeBSD.org> <2963143.tibTdn2gMF@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 29, 2018 at 11:28 AM, John Baldwin <jhb@freebsd.org> wrote: > On Wednesday, March 28, 2018 09:54:41 PM Dimitry Andric wrote: > > On 28 Mar 2018, at 18:51, John Baldwin <jhb@freebsd.org> wrote: > > > > > > Author: jhb > > > Date: Wed Mar 28 16:51:05 2018 > > > New Revision: 331686 > > > URL: https://svnweb.freebsd.org/changeset/base/331686 > > > > > > Log: > > > Expand remaining instances of 'make kernel' to buildkernel + > installkernel. > > > > > > The 'kernel' target is a bit more obscure compared to buildkernel and > > > installkernel. > > > > The 'kernel' target doesn't seem that obscure to me, it is clearly > > documented in build(7), right? In my opinion, the main advantage of > > separate build and install steps is that you can run the former as a > > non-privileged user, while only having to run the latter as super-user. > > I think it is still obscure even if in build(7). That said, after I had > done the commit I had a similar thought that splitting up the build and > install steps is useful in its own right, whether that is due to doing > builds as unprivileged, or doing builds on one machine or installs on > another. > Yea, I documented make kernel because it was fewer steps. I've used it 5 times in the last ~20 years or so since I did that. At the time, I think there was material talking about 'make world' still, so this was there for symmetry. Just like almost nobody uses make world today, almost nobody users make kernel. It is correct, and it works, but times and fashion has changed. We have a completely unpriv'd build now that needn't be in /usr/src, something that wasn't the case when the 'world' and 'kernel' targets were invented, IIRC. I didn't make a fuss when UPDATING changed because of the un-priv'd build, priv'd install separation that is so widely practiced, we barely need to call it out in UPDATING. And that 'barely' is covered completely by the commit to make this two steps. I'd only add I'd keep it documented in build(7), just like we keep world documented. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr0hKNvQCu26VEHFFyVypaJJ7vhUL6HmeRDcjaWtsNHtw>