Date: Thu, 24 Mar 2005 13:01:53 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20050324210153.GA6308@odin.ac.hmc.edu> In-Reply-To: <200503241555.59177.jhb@FreeBSD.org> References: <200503241751.j2OHpFQg063306@repoman.freebsd.org> <20050324200942.GK46915@wombat.fafoe.narf.at> <20050324201936.GA30850@odin.ac.hmc.edu> <200503241555.59177.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2005 at 03:55:59PM -0500, John Baldwin wrote: > On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote: > > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote: > > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote: > > > > Prior to C99, I think #error wasn't specified. C99 does specify it. > > > > > > C89/90 had #error too. > > > > I stand corrected. Now that I think about it, all but the perverse > > preprocessors would implement #error just by blowing up on an unknown > > directive so even that isn't an issue. In any case, I've made the > > change and the new code is at least shorter. It's really only there for > > people mucking with kernel internals who should be able to figure out > > what it means. >=20 > We could always just change CTASSERT() to use #error if that is better. #error would be better if we could change the CTASSERT prototype to output a useful error message. I suppose we could add a new macro that took an argument and implement CTASSERT in terms of it. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCQyrAXY6L6fI4GtQRAqzaAKC9DPLHJM3RbpFac9hWMkZIeF0hLgCdFqNe W1qn4si89nup4eYfx71HxSU= =eJUA -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050324210153.GA6308>