From owner-cvs-all Thu Oct 25 16:16:18 2001 Delivered-To: cvs-all@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 32BD237B405; Thu, 25 Oct 2001 16:16:15 -0700 (PDT) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.3/8.11.1) id f9PNCpI59363; Thu, 25 Oct 2001 16:12:51 -0700 (PDT) (envelope-from rizzo) Date: Thu, 25 Oct 2001 16:12:51 -0700 From: Luigi Rizzo To: "Justin T. Gibbs" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dcreg.h Message-ID: <20011025161251.J57392@iguana.aciri.org> References: <200110251743.f9PHhQ264466@freefall.freebsd.org> <200110252306.f9PN62Y59798@aslan.scsiguy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200110252306.f9PN62Y59798@aslan.scsiguy.com> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Oct 25, 2001 at 05:06:02PM -0600, Justin T. Gibbs wrote: > >luigi 2001/10/25 10:43:26 PDT > > > > Modified files: > > sys/pci if_dcreg.h > > Log: > > Defs for three (unused so far) bits in PCI command/status register > > were off by one bit. > > Shouldn't this driver just use the values in pcireg.h? possibly yes, but this is not my code, so i was merely fixing inconsistencies with the data sheets. Also, pcireg.h apparently is missing the definition for [the equivalent of] DC_CFCS_SYSERR_ENB, and seems to use 16-bit as opposed to 32-bit constants, so i can well understand why Bill redefined these constants on its own. cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message