From owner-svn-src-all@FreeBSD.ORG Fri Sep 6 10:36:48 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A7C6A871; Fri, 6 Sep 2013 10:36:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 191A82067; Fri, 6 Sep 2013 10:36:47 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r86AabfL008200; Fri, 6 Sep 2013 13:36:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r86AabfL008200 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r86AaaYb008199; Fri, 6 Sep 2013 13:36:36 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 6 Sep 2013 13:36:36 +0300 From: Konstantin Belousov To: David Chisnall Subject: Re: svn commit: r255297 - in head: include lib/libc/iconv lib/libiconv_modules Message-ID: <20130906103636.GF41229@kib.kiev.ua> References: <201309060946.r869kj8T064459@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wQFNOvpuONRGomCw" Content-Disposition: inline In-Reply-To: <201309060946.r869kj8T064459@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 10:36:48 -0000 --wQFNOvpuONRGomCw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 06, 2013 at 09:46:45AM +0000, David Chisnall wrote: > --- head/lib/libiconv_modules/Makefile Fri Sep 6 09:08:40 2013 (r255296) > +++ head/lib/libiconv_modules/Makefile Fri Sep 6 09:46:44 2013 (r255297) > @@ -2,6 +2,9 @@ > =20 > .include > =20 > +CFLAGS+=3D -Dbool=3D_Bool > +.export CFLAGS > + > SUBDIR=3D BIG5 DECHanyu EUC EUCTW GBK2K HZ ISO2022 JOHAB MSKanji UES UTF= 1632 \ > UTF7 UTF8 VIQR ZW iconv_none iconv_std mapper_646 mapper_none \ > mapper_parallel mapper_serial mapper_std mapper_zone This is extremely rude. Such things are traditionally (and properly) done with Makefile.inc in our tree. Look at the very beginning of mk/bsd.init.mk. But the whole commit is hack. If you want to use C99 _Bool, use it directly instead of obfuscating the code through the build system. --wQFNOvpuONRGomCw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQIcBAEBAgAGBQJSKbA0AAoJEJDCuSvBvK1BbeIQAJZmJMD9vDtHqfoz/RphPw+/ JFWZxdfLTIps5go/+zGHOY75GMNW4ag0B+TX5gvP/+5lW5P/lzPzs9+ViEQUdunl bh+EFjUGiMUjcvmdvz8yYFjH8iH8zqfLlmhPIuarahsRjMxAp7UvQc9rLQEbBC6Y VYgeBsW9FHeFS0LLQg+5gqmaZU3Rlx3+4F+I2iSrHaWKa1U+LPKXndb7MayTz7KB jm7Af1Ztmux9zbetNALZEtOYsFBncKlG4v9tAWiN3MJjm0Z5sqqX1ekGeiVrhVgl 9dPgdUbWh1Emcd1UdU9aVzZj3E5scbMTS6lqo/e+d37/8y25QNr2XFnKwXLGoNBq nHaZjIU3z5tw8PwtRQ7OFkONiHlivGzbejxc7S1gBfcvNHKk90JtWnMm8PFZ+MHb KeTRlrogtFdVRs5C87byWoIozFDU+5Y/QdTsQKWeZiZazQqbTZWCEtChlN6vSz++ UV+hMsSer4rJfRk2VPl5O+/3CYbrjZFBnW1Enhvnfny9hBMrozPx9FooMTFj7Rre A+kEv6JnLziTNjr/lixSC+UXvU+OSbppdBH5qn9DmCwZWlk+WRZdsKVNk3jPnUgF ygs0uFMh/73JtcM6W7Hsy/xA4bYEzNl9G5VhEpEnixvBqdiPX/0KceQtx0Nvia/c Zf5iVLjpOxVX/y4Fkmlt =n7+f -----END PGP SIGNATURE----- --wQFNOvpuONRGomCw--