Date: Wed, 1 Mar 2017 17:59:16 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers <src-committers@freebsd.org>, Ian Lepore <ian@freebsd.org>, svn-src-all@freebsd.org, "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, svn-src-head@freebsd.org, Ngie Cooper <ngie@freebsd.org> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <20170301165916.kuizbr2w5l2beoac@ivaldir.etoilebsd.net> In-Reply-To: <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net> References: <20170301163050.GA81295@FreeBSD.org> <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--ati2n6uvzjsuspua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Mar 01, 2017 at 08:43:55AM -0800, Rodney W. Grimes wrote:
> > On Wed, Mar 01, 2017 at 08:54:51AM -0700, Ian Lepore wrote:
> > > ...
> > > You're not the only one who has diffed build output logs (I suspect
> > > anyone who has to maintain a non-trivial build infrastructure has done
> > > so), and you're not the only one who thinks that changing relative
> > > paths to absolute is a bad idea.
> >=20
> > +1. Relative paths are so much nicer (and they are usually shorter as
> > well). I didn't respond to these changes only because .CURDIR itself
> > is expanded to a full path, so arguing if one wants some ../../ within
> > what's inherently starts with a slash seems pointless.
>=20
> True, in the normal use relative paths are shorter, but in how this
> actually all goes about the use of ${SRCTOP} vs ${.CURDIR} yeilds
> both short strings in the Makefile, and shorter output in the log.
And making the logs with relative path would actually be hard given how make
works or maybe I'm missing something
>=20
> Your reasoning is also why I was somewhat quiet on it when I saw it
> start to be merged into -stable, which was the first place I saw it.
> I *thought* at that point the whole of -current had already been
> converted and this was just coming over with other nearby changes.
>=20
> I believe we have some other full path things that have crept
> forward into the production release, but that may be in ports
> only. Nope bad full paths links I found in just a few seconds:
>=20
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chfn -> /usr/bin/chpass
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chsh -> /usr/bin/chpass
> lrwxr-xr-x 1 root wheel 7 Nov 30 02:27 cpio -> bsdcpio
> lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 mailq -> /usr/sbin/mai=
lwrapper
> lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 newaliases -> /usr/sbi=
n/mailwrapper
> lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pgrep -> /bin/pgrep
> lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pkill -> /bin/pkill
> lrwxr-xr-x 1 root wheel 6 Nov 30 02:27 tar -> bsdtar
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchfn -> /usr/bin/chp=
ass
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchpass -> /usr/bin/c=
hpass
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchsh -> /usr/bin/chp=
ass
> lrwxr-xr-x 1 root wheel 15 Nov 30 02:27 yppasswd -> /usr/bin/p=
asswd
>=20
> This breaks the abilty to mv usr/bin and have the right stuff
> happen if you invoke usr/bin.moved/mailq.
Almost every was with absolute path for the symlinks, we have changed "rece=
ntly"
most (all?) of the symlinks for libraries (.so files) into relative to be a=
ble
to have a proper sysroot, and yes I agree we should go further and make all=
the
symlinks relative which is very easy install just add the option -l sr and =
magic
happen :)
Best regards,
Bapt
--ati2n6uvzjsuspua
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli2/eEACgkQY4mL3PG3
PlrDCA/9EWm78GgYCgaRDk0Yol5nzMotpoLcH4f/A7+n6n33NKNjukgtpI+MlXHe
taOU5k2cx4KQR845aBKAFzyAe1G90yoy+AW0Ib8g89IZeQcS3H1dJJsH/srMqke6
iPYsQN+MBfn5vf5JMz56BTfbzVEPpd/TVXes9DwciAKF0oH0qdNif+dYawmPZD3V
EHt4IRC0tJrw1rgmLrZCPBcn6m0StSxwN20GXENyLCHOFUDsNcCMe6BaTtk2Fm+l
iXfp52PYz3C9D1nSi6gdFe1kgHdVRDWeZltUnWFOuz2uN83ohmzXvJ/lqwLhaMsA
I2Nx2F43+2D+hoA6CdBkFvKKKNNzD9Js0qjfz5j3TOl8H6DOlZZPE7S8SnYa7Tw0
0zViqkFAUi4tKIIg79BUZjAUNZBsNjeqCzm246i/Zn5cRviL+pSPnz9ySBSOcIQ/
SCpLmvkslFFaRt5WZBGZUq4JP2L5zVuacdvjmWU9IIfwCf9RNtqCiUEsSJrk3vHt
qizj1SvQMdkqRO2lJJ3FrnGcxiTjpF245ww9qEC9HRHi5gBVTCNSg/qk9w21U3VX
b/hgLH3+Ms/PNTcjNEMPbrPN4GcuLYOubug8F21tDPrBQhp65d8kAXs2IGs+E8YU
lrSEcjhV6QrY9OSv91Jesx43wL8Bu9Zqywmal7wQskV0rGWk984=
=pd+Z
-----END PGP SIGNATURE-----
--ati2n6uvzjsuspua--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170301165916.kuizbr2w5l2beoac>