Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Dec 2002 20:16:39 +0100 (CET)
From:      Soeren Schmidt <sos@spider.deepcore.dk>
To:        Andrew Gallatin <gallatin@cs.duke.edu>
Cc:        Kris Kennaway <kris@obsecurity.org>, sos@FreeBSD.ORG, current@FreeBSD.ORG
Subject:   Re: Another INVARIANTS panic with ata driver
Message-ID:  <200212061916.gB6JGdEk009375@spider.deepcore.dk>
In-Reply-To: <15856.60167.577649.503653@grasshopper.cs.duke.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
It seems Andrew Gallatin wrote:
> 
> Kris Kennaway writes:
>  > I got this on one of the gohan machines overnight.  These machines
>  > have failing disks -- I get a lot of hard read errors, but the
>  > INVARIANTS panic could better be replaced by something else.
>  > 
>  > I reported another instance of this to sos a few weeks ago but didn't
>  > hear a reply.
>  > 
> 
> I posted a patch for this earlier this week.  No reply from sos yet.
> 
> Try the following patch (its against stable but should work on
> current).  The problem is that ata_raiddisk_attach fails, causing the
> adp to be freed, so ad_print is called with a bogus pointer.  adp is
> an alias fro atadev->driver, so checking that atadev->driver != NULL
> is one way to fix this panic.

I have a semilar fix here, re@ will decide if it can go in...

-Søren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212061916.gB6JGdEk009375>