From owner-svn-src-head@FreeBSD.ORG  Thu Dec 31 00:01:49 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAC2E106566C
	for <svn-src-head@freebsd.org>; Thu, 31 Dec 2009 00:01:49 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 6514D8FC13
	for <svn-src-head@freebsd.org>; Thu, 31 Dec 2009 00:01:48 +0000 (UTC)
Received: (qmail 27180 invoked by uid 399); 31 Dec 2009 00:01:48 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 31 Dec 2009 00:01:48 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4B3BE9EF.60400@FreeBSD.org>
Date: Wed, 30 Dec 2009 16:01:51 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Thunderbird 2.0.0.23 (X11/20091206)
MIME-Version: 1.0
To: Ruslan Ermilov <ru@FreeBSD.org>
References: <200912302301.nBUN1nE5075671@svn.freebsd.org>
In-Reply-To: <200912302301.nBUN1nE5075671@svn.freebsd.org>
X-Enigmail-Version: 0.96.0
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r201290 - head/usr.bin/fetch
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Dec 2009 00:01:50 -0000

Ruslan Ermilov wrote:
> Author: ru
> Date: Wed Dec 30 23:01:49 2009
> New Revision: 201290
> URL: http://svn.freebsd.org/changeset/base/201290
> 
> Log:
>   Treat an empty argument as an error, instead of fetching the
>   contents of the root directory.

I'm pretty sure that you just broke portmaster's package functionality
with this change. I'm doing: fetch -q -o - ${sitepath} 2>/dev/null
to get the list of what is available on the package sites.

Is there a reason that you need to make this change?


Doug


> Modified:
>   head/usr.bin/fetch/fetch.c
> 
> Modified: head/usr.bin/fetch/fetch.c
> ==============================================================================
> --- head/usr.bin/fetch/fetch.c	Wed Dec 30 22:46:08 2009	(r201289)
> +++ head/usr.bin/fetch/fetch.c	Wed Dec 30 23:01:49 2009	(r201290)
> @@ -340,6 +340,11 @@ fetch(char *URL, const char *path)
>  		fetchDebug = 1;
>  
>  	/* parse URL */
> +	url = NULL;
> +	if (*URL == '\0') {
> +		warnx("empty URL");
> +		goto failure;
> +	}
>  	if ((url = fetchParseURL(URL)) == NULL) {
>  		warnx("%s: parse error", URL);
>  		goto failure;
> 


-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/