From owner-svn-src-all@freebsd.org Sun Jul 1 19:47:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFE0BFD5734 for ; Sun, 1 Jul 2018 19:47:21 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x22c.google.com (mail-yw0-x22c.google.com [IPv6:2607:f8b0:4002:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6855B7B0C1 for ; Sun, 1 Jul 2018 19:47:21 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x22c.google.com with SMTP id w13-v6so5985003ywa.5 for ; Sun, 01 Jul 2018 12:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l1T7lhu9bqcnHtRuyPXVIUIh0TtiHxFzWTqQQ38KPvE=; b=mvgNxEVrCyt2OtHEcl6NUxA/bQapA7OSTqGPTv6lCQp+G6xlAf9ZmiYrRFney94Edy DqcMGtna+sO8o3SjcqpbmhjnEemF579FzDOoUXklZktLQ1Ip1V20GZg25/GC4EYnMrQM Sn/2Scup2A3yBiVWWaz8JO8FNPQ5//RyADxiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l1T7lhu9bqcnHtRuyPXVIUIh0TtiHxFzWTqQQ38KPvE=; b=JJVgACN7ZhV+j8qzGgjvI7J5Lqqv3/VYpv7+pTzUz+loy67QgAeYhEZeOkzEa+aY3e V3VKoIpiJKt9dKKOP5AcZrDfN35TfYRl0n9btnpzP6mc3XWEBXvD0SLjVpA0qikghFN1 YPlffoNA/nzrjytRFIblMLtC3c5t77a6PN9zWNYwMq4arUaSfpqtGtr5chXs/UqcJiUe i5czV888ABIGsgb6IYPh8nlzkmZ62GanfVg7rJrzj3GPHiKwOeZEQY/8Ne2+CrSotdja PfG+y5hSIwD2ZNcrL861GxO0WLPUgQMU4t7oSKezfF7Ufhn2TSkPsinxWMwQIuUk5XnI wWqg== X-Gm-Message-State: APt69E1ojY9EFn05vkZigjh7ff/FE1ZWPTStvt9g69AMvbKHT3Me6KE0 Uf4edWjvuVgNYosIaoCCzrBD1G46UwOdAWM9GMDD5Q== X-Google-Smtp-Source: AAOMgpd7uQ9/+R0z0I2SdaDMbNM3T9pPu46tXzjL+qXsvbi0qZ4Z3sSWQ4s2xYRSyrEyMRrLCpVsJsKjw/tX+Q5O+Yw= X-Received: by 2002:a81:2c56:: with SMTP id s83-v6mr11252572yws.387.1530474440438; Sun, 01 Jul 2018 12:47:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:870e:0:0:0:0:0 with HTTP; Sun, 1 Jul 2018 12:46:49 -0700 (PDT) In-Reply-To: References: <201807010532.w615W44e042172@repo.freebsd.org> From: Eitan Adler Date: Sun, 1 Jul 2018 12:46:49 -0700 Message-ID: Subject: Re: svn commit: r335836 - head/usr.bin/top To: "Conrad E. Meyer" Cc: Daichi GOTO , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 19:47:22 -0000 On 1 July 2018 at 10:08, Conrad Meyer wrote: > Hi Daichi, > > > > I don't think code to decode UTF-8 belongs in top(1). I don't know > what the goal of this routine is, but I doubt this is the right way to > accomplish it. For the record, I agree. This is why I didn't click "accept" on the revision. I don't fully oppose leaving it in top(1) for now as we work out the API, but long term its the wrong place. https://reviews.freebsd.org/D16058 is the review. -- Eitan Adler