Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 May 2019 16:36:12 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r244943 - in head/sys/dev/ath/ath_hal: ar5416 ar9002
Message-ID:  <20190522163612.GA4626@FreeBSD.org>
In-Reply-To: <201301020038.r020c1fN074342@svn.freebsd.org>
References:  <201301020038.r020c1fN074342@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 02, 2013 at 12:38:01AM +0000, Adrian Chadd wrote:
> New Revision: 244943
> URL: http://svnweb.freebsd.org/changeset/base/244943
> 
> Log:
>   Bring over the basic spectral scan framework code from Qualcomm Atheros.
>   
>   This includes the HAL routines to setup, enable/activate/disable spectral
>   scan and configure the relevant registers.
>   
>   Obtained from:	Qualcomm Atheros
> 
> Added:
>   head/sys/dev/ath/ath_hal/ar5416/ar5416_spectral.c
> 
> ...
> +	if (ss->ss_period != HAL_SPECTRAL_PARAM_NOVAL) {
> +		val &= ~AR_PHY_SPECTRAL_SCAN_PERIOD;
> +		val |= SM(ss->ss_period, AR_PHY_SPECTRAL_SCAN_PERIOD);
> +	}
> +
> +	if (ss->ss_period != HAL_SPECTRAL_PARAM_NOVAL) {
> +		val &= ~AR_PHY_SPECTRAL_SCAN_PERIOD;
> +		val |= SM(ss->ss_period, AR_PHY_SPECTRAL_SCAN_PERIOD);
> +	}

PVS Studio complains here: warning: V581 The conditional expressions of
the 'if' operators situated alongside each other are identical.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190522163612.GA4626>