Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jan 2017 12:23:36 -0500
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r311860 - head/sys/net80211
Message-ID:  <20170110172336.phqcy57zszifujaj@mutt-hardenedbsd>
In-Reply-To: <201701100721.v0A7L7ip039127@repo.freebsd.org>
References:  <201701100721.v0A7L7ip039127@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--clqiuqvuihafj6vh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 10, 2017 at 07:21:07AM +0000, Adrian Chadd wrote:
> Author: adrian
> Date: Tue Jan 10 07:21:07 2017
> New Revision: 311860
> URL: https://svnweb.freebsd.org/changeset/base/311860
>=20
> Log:
>   [net80211] add VHT action frame placeholders for when it's time to impl=
ement.
>=20
> Modified:
>   head/sys/net80211/ieee80211_vht.c
>=20
> Modified: head/sys/net80211/ieee80211_vht.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/net80211/ieee80211_vht.c	Tue Jan 10 05:37:53 2017	(r311859)
> +++ head/sys/net80211/ieee80211_vht.c	Tue Jan 10 07:21:07 2017	(r311860)
> @@ -85,9 +85,49 @@ __FBSDID("$FreeBSD$");
>   * Look at mac80211/vht.c:ieee80211_vht_handle_opmode() for further deta=
ils.
>   */
> =20
> +static int
> +vht_recv_action_placeholder(struct ieee80211_node *ni,
> +    const struct ieee80211_frame *wh,
> +    const uint8_t *frm, const uint8_t *efrm)
> +{
> +
> +	ieee80211_note(ni->ni_vap, "%s: called; fc=3D0x%.2x/0x%.2x",
> +	    __func__,
> +	    wh->i_fc[0],
> +	    wh->i_fc[1]);
> +
> +	return (0);
> +}
> +
> +static int
> +vht_send_action_placeholder(struct ieee80211_node *ni,
> +    int category, int action, void *arg0)
> +{
> +
> +	ieee80211_note(ni->ni_vap, "%s: called; category=3D%d, action=3D%d",
> +	    __func__,
> +	    category,
> +	    action);
> +	return (EINVAL);
> +}
> +

This broke the build for kernel configurations that don't have the
IEEE80211_DEBUG option set. ieee80211_note is only a valid function when
IEEE80211_DEBUG is defined.

Thanks,

--=20
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

--clqiuqvuihafj6vh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlh1GJgACgkQaoRlj1JF
bu4kVA/8D5yu2GTLmnntoRnrZjc8GKFK8Jzoph6DakrCTdE1m2/pHv7E12tHtEN6
13Aj5J73qUZqRB70ukB2MSbbLnFNE017fFOu0gV8UIZbkopzTVx7hOzKbVt1BB2T
z4mz2Fn2V3cvx9DqeKsluM0JOh94uddL63SaTZb6vlFCGPHWtXuZRfkU8Q4T7KlU
52IAwywTFls50idCdYnD1GIZ/hWAnhPhqCA0rdi5EE+BSq/+XrdSbDnyJQosXO+7
IhF0fnh+CuTXOBnzpsiX3EtMa+q3jJB76DGmiXe80qQ2Av78XwhDOYyQJdZx0EHC
WOlqk4tlQ7TRDjY3WJXhWrCyZzWCyTdeBVuc1+Ujlw9OinOpHn7FH9aZ85EihjoZ
6qKNg8SRP+v0wugfd/W6wn5cu8BJgNzObbsMxEfXj+jDe9hu8KJYO8X+Ea7GjAvO
fSEYZGmO2OfucLm/3pfmsaAe9zoaDCl+ZACq3grmRFC2AQhYsUIE6NPjuZXt1b1x
IfFq2A8CUIniImp4c9IJur92wvr7bT+LPYYm44Z7JAaTTJWviuz6fb2RDBiHfnBF
His7QrsA5jRAO3PMgkUveTZWPq9M0oTM+XuVmfR3G1hdFwzmvmjyJ3aRXfFv1Cwc
z4jpwd2ryuF7YI7Rte6L38JqvIefhWWwNMctzFgH6up3ssxlV24=
=7MVb
-----END PGP SIGNATURE-----

--clqiuqvuihafj6vh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170110172336.phqcy57zszifujaj>