From owner-svn-src-projects@freebsd.org Mon Oct 23 00:57:00 2017 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A5A2E3B841 for ; Mon, 23 Oct 2017 00:57:00 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 09EFF802B5; Mon, 23 Oct 2017 00:56:59 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v9N0uxSW055062; Mon, 23 Oct 2017 00:56:59 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v9N0uxYu055061; Mon, 23 Oct 2017 00:56:59 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201710230056.v9N0uxYu055061@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Ngie Cooper Date: Mon, 23 Oct 2017 00:56:59 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r324889 - projects/runtime-coverage/share/mk X-SVN-Group: projects X-SVN-Commit-Author: ngie X-SVN-Commit-Paths: projects/runtime-coverage/share/mk X-SVN-Commit-Revision: 324889 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 00:57:00 -0000 Author: ngie Date: Mon Oct 23 00:56:59 2017 New Revision: 324889 URL: https://svnweb.freebsd.org/changeset/base/324889 Log: Need to make all of the variables immediate, or the last value for _gcno_dir wins This is particularly fun when relative paths are embedded in SRCS, like lib/libclang_rt does (which I argue is ripe for corruption via parallel builds). Modified: projects/runtime-coverage/share/mk/bsd.cov.mk Modified: projects/runtime-coverage/share/mk/bsd.cov.mk ============================================================================== --- projects/runtime-coverage/share/mk/bsd.cov.mk Mon Oct 23 00:44:18 2017 (r324888) +++ projects/runtime-coverage/share/mk/bsd.cov.mk Mon Oct 23 00:56:59 2017 (r324889) @@ -25,8 +25,8 @@ FILESGROUPS+= GCNOS CLEANFILES+= ${GCNOS} .for _gcno in ${GCNOS} -_gcno_dir= ${COVERAGEDIR}${_gcno:H:tA} -GCNOSDIR_${_gcno:T}= ${_gcno_dir} +_gcno_dir:= ${COVERAGEDIR}${_gcno:H:tA} +GCNOSDIR_${_gcno:T}:= ${_gcno_dir} # Create _gcno_dir if it doesn't already exist. .if !target(${DESTDIR}${_gcno_dir}) ${DESTDIR}${_gcno_dir}: