From owner-freebsd-ports-bugs@freebsd.org  Wed Nov  2 04:47:13 2016
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D505BC2A3CE
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Wed,  2 Nov 2016 04:47:13 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D72A1FA4
 for <freebsd-ports-bugs@FreeBSD.org>; Wed,  2 Nov 2016 04:47:13 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA24lCNQ049020
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 2 Nov 2016 04:47:13 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 213939] [NEW PORT] games/EmptyEpsilon: A spaceship bridge
 simulator game
Date: Wed, 02 Nov 2016 04:47:13 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jbeich@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-213939-13-ob0gMk4ptH@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213939-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-213939-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Nov 2016 04:47:14 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213939

Jan Beich (mail not working) <jbeich@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich@FreeBSD.org

--- Comment #3 from Jan Beich (mail not working) <jbeich@FreeBSD.org> ---
Comment on attachment 176359
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176359
shar archive

> XLICENSE_FILE=3D	${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
                                  ^^^^^^^^^^^^
Why not ${WRKSRC}/LICENSE ? Otherwise, maybe substitute one more word e.g.,

  -LICENSE_FILE=3D        ${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
  +LICENSE_FILE=3D        ${WRKDIR}/${GH_PROJECT}-${DISTVERSIONFULL}/LICENSE

> XLIB_DEPENDS=3D	libsfml-system.so:devel/sfml

Fixed in ports r425104, so EmptyEpsilon builds fine on 9.x. ;)

> XCMAKE_ARGS=3D	-DSERIOUS_PROTON_DIR=3D../SeriousProton-${DISTVERSIONFULL}/

To make it less fragile maybe use WRKSRC_<group> e.g.,

  -CMAKE_ARGS=3D  -DSERIOUS_PROTON_DIR=3D../SeriousProton-${DISTVERSIONFULL=
}/
  +CMAKE_ARGS=3D  -DSERIOUS_PROTON_DIR=3D"${WRKSRC_sproton}/"

> XPATCH_WRKSRC=3D	${WRKDIR}

Why? Only post-patch below touches the files outside of WRKSRC.

> Xpost-patch:
> X	@${REINPLACE_CMD} -e 's|basepath + |"${PREFIX}/share/emptyepsilon/" + b=
asepath + |' \
> X		${WRKDIR}/SeriousProton-*/src/resources.cpp
> X	@${REINPLACE_CMD} -e 's|loadFromFile("resources/"|loadFromFile("${PREFI=
X}/share/emptyepsilon/resources/"|' \
> X		${WRKDIR}/SeriousProton-*/src/postProcessManager.cpp

Can you keep letter case consistent: bin/EmptyEpsilon vs. share/emptyepsilon
vs. ~/.emptyepsilon ? If you pick lower case rename the port to match it e.=
g.,

  -PORTNAME=3D      EmptyEpsilon
  +PORTNAME=3D      emptyepsilon
  ...
  -GH_ACCOUNT=3D    daid
  +GH_TUPLE+=3D     daid:EmptyEpsilon:${DISTVERSIONFULL}

> sed 's/^X//' >games/EmptyEpsilon/pkg-descr << '930a933c75becaad7502e40f41=
a5a7c0'
> XEmptyEpsilon is a spaceship bridge simulator game.

The first line in pkg-descr can be dropped as it matches ${COMMENT} in Make=
file
and is obvious from reading the rest.

--=20
You are receiving this mail because:
You are the assignee for the bug.=