From owner-svn-src-all@FreeBSD.ORG  Thu Aug 22 10:07:45 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id CF4B7EED
 for <svn-src-all@freebsd.org>; Thu, 22 Aug 2013 10:07:45 +0000 (UTC)
 (envelope-from mailer-daemon@vniz.net)
Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com
 [209.85.215.172])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 67A382EE8
 for <svn-src-all@freebsd.org>; Thu, 22 Aug 2013 10:07:45 +0000 (UTC)
Received: by mail-ea0-f172.google.com with SMTP id r16so807412ead.3
 for <svn-src-all@freebsd.org>; Thu, 22 Aug 2013 03:07:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:openpgp:content-type
 :content-transfer-encoding;
 bh=jPd64LOJ2LCRbl5L+RL17xcvyMBAaQelZ55wHWlPygU=;
 b=UBdY/5thG0jvMfBT0bo+ZQoq4jlwq2rs+YTA9nb12AlGXSIHzjxy9/yWQTaqKvPrfs
 ZkXT1akQW7PYqZ7ClcHAZbzMwphQgiDus1sC7d1YcMLC1TwSBfapTth1sVi0c+j1GXlE
 /G1frdOrqWeqN01mKdye+YPlNYJN3Ai4gJBCUrn1ketLxFfUrF+VvQ7zol+vj05fORLW
 GXKRxGPYjyqugahMu2+o9zWkoxQfhYsh5oiBtpJcgIw9UYUXuaGFrG25pZ7M9uffO0IU
 7xpYriwpDA1Xy2J+HPKglufTxt0ADoWVqQNa8wiqsGo+YJWmD3+DNINAc8QagYSal5J9
 JrOw==
X-Gm-Message-State: ALoCoQllKdF7Xz+Sxyo72QHLAxWjjqHE43Vt5vhfC9YRnSmSKW5I5hL3aCHPguY438k/56QdKqNR
X-Received: by 10.15.27.133 with SMTP id p5mr1868011eeu.65.1377165682149;
 Thu, 22 Aug 2013 03:01:22 -0700 (PDT)
Received: from [192.168.1.2] ([89.169.173.68])
 by mx.google.com with ESMTPSA id b45sm16365250eef.4.1969.12.31.16.00.00
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Thu, 22 Aug 2013 03:01:21 -0700 (PDT)
Message-ID: <5215E16E.4080207@freebsd.org>
Date: Thu, 22 Aug 2013 14:01:18 +0400
From: Andrey Chernov <ache@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Jilles Tjoelker <jilles@stack.nl>
Subject: Re: svn commit: r254600 - head/lib/libutil
References: <201308211646.r7LGk6eV051215@svn.freebsd.org>
 <5214F72B.7070006@freebsd.org> <20130821190309.GB52908@omg>
 <20130821202725.GA4991@stack.nl> <20130821212413.GC52908@omg>
 <20130821213755.GA8052@stack.nl>
In-Reply-To: <20130821213755.GA8052@stack.nl>
OpenPGP: id=964474DD
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Sergey Kandaurov <pluknet@freebsd.org>, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 10:07:45 -0000

On 22.08.2013 1:37, Jilles Tjoelker wrote:
>>         if (number == UINTMAX_MAX && errno == ERANGE) {
>>                 return (-1);
>>         }
>>  
>> +       if (errno == 0)
>> +               errno = saved_errno;
>> +
> This looks good to me.
> 

Just being nitpicking) number == UINTMAX_MAX check is unneeded.

-- 
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r