From owner-svn-ports-all@freebsd.org  Wed Aug 30 21:22:53 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA970E0A87E;
 Wed, 30 Aug 2017 21:22:53 +0000 (UTC)
 (envelope-from dan@langille.org)
Received: from clavin2.langille.org (clavin2.langille.org [199.233.228.197])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "clavin.langille.org",
 Issuer "BSD Cabal Headquarters" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id C8C1A80A6B;
 Wed, 30 Aug 2017 21:22:53 +0000 (UTC)
 (envelope-from dan@langille.org)
Received: from (clavin2.int.langille.org (clavin2.int.unixathome.org
 [10.4.7.7]) (Authenticated sender: hidden) with ESMTPSA id CE1F71F94C ; 
 Wed, 30 Aug 2017 21:22:51 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay
From: Dan Langille <dan@langille.org>
In-Reply-To: <1sns-okrn-wny@FreeBSD.org>
Date: Wed, 30 Aug 2017 17:22:50 -0400
Cc: Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <01088B7D-A035-458C-9A23-70EA8381AE66@langille.org>
References: <201708301932.v7UJW1tH094312@repo.freebsd.org>
 <1sns-okrn-wny@FreeBSD.org>
To: Jan Beich <jbeich@FreeBSD.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Aug 2017 21:22:54 -0000

> On Aug 30, 2017, at 4:36 PM, Jan Beich <jbeich@FreeBSD.org> wrote:
>=20
> Dan Langille <dvl@FreeBSD.org> writes:
>=20
>> Author: dvl
>> Date: Wed Aug 30 19:32:00 2017
>> New Revision: 448998
>> URL: https://svnweb.freebsd.org/changeset/ports/448998
>>=20
>> Log:
>>  Add base/port options for libpcap
> [...]
>> +OPTIONS_DEFINE=3D	LIBPCAP_BASE LIBPCAP_PORTS
> [...]
>> +OPTIONS_SINGLE=3D	SG1
>> +OPTIONS_SINGLE=3D	LIBPCAP_BASE LIBPCAP_PORTS
>=20
> _SINGLE declares a group of options, not the option themselves.
> When _SINGLE is overloaded by _DEFINE the option is no longer =
exclusive.
>=20
> Did you forget to adjust Porter's Handbook example?

So it seems, thank you.

> OPTIONS_SINGLE=3D	LIBPCAP
> OPTIONS_SINGLE_LIBPCAP=3D	LIBPCAP_BASE LIBPCAP_PORTS
>=20
>> +OPTIONS_DEFAULT=3D	LIBPCAP_BASE
>=20
> Doesn't work if net/libpcap is installed as a dependency by another
> (unrelated) port.

What do you mean by doesn't work?

tcpreplay will work. It will use the lib in base, and ignore the lib =
provided by net/libpcap

Do I misunderstand?

> +LIBPCAP_PORTS_BUILD_DEPENDS=3D	=
${LOCALBASE}/lib/libpcap.a:net/libpcap
>> +LIBPCAP_PORTS_LIB_DEPENDS=3D	libpcap.so:net/libpcap
>=20
> Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS.

I don't understand the .1 - did i miss another handbook item?

Thank you.

--=20
Dan Langille - BSDCan / PGCon
dan@langille.org