Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jan 2015 05:40:37 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kurt Jaeger <pi@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r376996 - in head/net-mgmt: . statsite statsite/files
Message-ID:  <20150114054037.GA45207@FreeBSD.org>
In-Reply-To: <201501140525.t0E5PjxZ062842@svn.freebsd.org>
References:  <201501140525.t0E5PjxZ062842@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 14, 2015 at 05:25:45AM +0000, Kurt Jaeger wrote:
> New Revision: 376996
> URL: https://svnweb.freebsd.org/changeset/ports/376996
> QAT: https://qat.redports.org/buildarchive/r376996/
> 
> [...]
> +BUILD_DEPENDS=	scons:${PORTSDIR}/devel/scons

Any reason why USES=scons was not suitable here?

> +do-build:
> +	cd ${WRKSRC} && make

do-build recipe looks very bogus (and even if it's not, literal "make"
should not be used, we have ${MAKE_CMD} for that; have a look at default
do-build implementation in bpm).

> +do-install:
> +	${STRIP_CMD} ${WRKSRC}/statsite
> +	${CP} ${WRKSRC}/statsite ${STAGEDIR}/${PREFIX}/bin/

Please educate submitter that binaries are meant to be installed with
${INSTALL_PROGRAM} which does the stripping itself.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150114054037.GA45207>