Date: Wed, 24 Mar 2010 21:38:11 +0000 (UTC) From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com> To: freebsd-ipfw@freebsd.org Subject: ipfw: missing action Message-ID: <hoe0o3$lek$1@dough.gmane.org>
next in thread | raw e-mail | index | archive | help
Another victim of recent MFC:
# ipfw -n add 00100 set 2 allow all from any to any via lo0
ipfw: missing action
Bug also exists on head.
Someone should add "write IPFW testsuite" to FreeBSD project ideas ;)
diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c
--- /usr/src/sbin/ipfw/ipfw2.c 2010-03-24 04:19:34.000000000 +0100
+++ /home/marcin/p/bugfix/ipfw/ipfw2.c 2010-03-24 22:07:33.000000000 +0100
@@ -2656,7 +2656,7 @@
}
/* [set N] -- set number (0..RESVD_SET), optional */
- if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) {
+ if (av[0] && av[1] && _substrcmp(*av, "set") == 0) {
int set = strtoul(av[1], NULL, 10);
if (set < 0 || set > RESVD_SET)
errx(EX_DATAERR, "illegal set %s", av[1]);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?hoe0o3$lek$1>