From owner-cvs-src@FreeBSD.ORG Sat Feb 4 00:09:48 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA76E16A420; Sat, 4 Feb 2006 00:09:48 +0000 (GMT) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.183]) by mx1.FreeBSD.org (Postfix) with ESMTP id 049C343D48; Sat, 4 Feb 2006 00:09:47 +0000 (GMT) (envelope-from max@love2party.net) Received: from [84.163.242.197] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu9) with ESMTP (Nemesis), id 0ML2xA-1F5Azq1Sqt-0004Em; Sat, 04 Feb 2006 01:09:46 +0100 From: Max Laier Organization: FreeBSD To: "Devon H. O'Dell" Date: Sat, 4 Feb 2006 01:11:03 +0100 User-Agent: KMail/1.9.1 References: <200602032350.k13NoQ1c047653@repoman.freebsd.org> <20060203155613.J41267@knight.iXsystems.com> In-Reply-To: <20060203155613.J41267@knight.iXsystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3663192.hHddW2R9lI"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200602040111.12261.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Robert Watson , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/security/audit audit_arg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2006 00:09:48 -0000 --nextPart3663192.hHddW2R9lI Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 04 February 2006 00:56, Devon H. O'Dell wrote: > On Fri, Feb 03, 2006 at 11:50:26PM +0000, Robert Watson wrote: > > rwatson 2006-02-03 23:50:26 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/security/audit audit_arg.c > > Log: > > Fix INVARIANTS build on amd64; (unsigned unsigned long) !=3D u_int64_= t. > > Not to be pedantic or rude or anything, but don't we use > uint64_t these days? And shouldn't we use %ju for printing > these types? As this is somewhat vendor code, I think u_int64_t is okay. As for %ju, I= =20 think it's stupid. I even believe that %llu shouldn't raise an error when= =20 printing unsigned integers with sizeof(arg_type) =3D=3D sizeof(long long) -= this=20 should be possible as a compile time assert in whatever code is responsible= =20 for this. We are seeing this type of porting problem over and over again, there shoul= d=20 be a better sollution. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart3663192.hHddW2R9lI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD4/EgXyyEoT62BG0RAnkuAJ4mvyyOPt5B/PIWD3hjv8wsKve3HwCfdZBu 0+IAfQaiHpAojb99IUqsdzE= =U864 -----END PGP SIGNATURE----- --nextPart3663192.hHddW2R9lI--