Date: Wed, 1 Oct 2014 23:25:15 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Glen Barber <gjb@freebsd.org> Cc: svn-src-stable@freebsd.org, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, svn-src-stable-10@freebsd.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r272372 - stable/10/bin/rm Message-ID: <CAGHfRMCLO-i%2BFpmrTF6RzAPb1owECKG9Joh6cRZd9c8Cc0%2BJRw@mail.gmail.com> In-Reply-To: <20141002061628.GO1275@hub.FreeBSD.org> References: <201410011618.s91GIfR5071251@svn.freebsd.org> <20141002141656.Y1807@besplex.bde.org> <20141002061628.GO1275@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 1, 2014 at 11:16 PM, Glen Barber <gjb@freebsd.org> wrote: > On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: >> On Wed, 1 Oct 2014, Glen Barber wrote: >> >> >Log: >> > MFC r268376 (imp): >> > >> > rm -rf can fail sometimes with an error from fts_read. Make it >> > honor fflag to ignore fts_read errors, but stop deleting from >> > that directory because no further progress can be made. >> >> I asked for this to be backed out in -current. It is not suitable for MFC. >> > > It fixes an immediate issue that prevents high-concurrent make(1) jobs > from stomping over each other. The real problem is noted in this bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 ; the SUBDIR_PARALLEL logic is executing multiple instances of the clean/cleandir .PHONY targets. I agree with bde@ that this commit is papering over a bigger problem, but it's annoying enough and causes enough false positives that I understand why gjb@ MFCed the commit imp@ did in head. Thank you..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMCLO-i%2BFpmrTF6RzAPb1owECKG9Joh6cRZd9c8Cc0%2BJRw>