Date: Fri, 13 May 2011 19:01:32 +0400 From: Pan Tsu <inyaoo@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/157009: [patch] ftp/curl: respect DEBUG_FLAGS for CURL_DEBUG/TRACKMEMORY Message-ID: <86hb8yir03.fsf@gmail.com> Resent-Message-ID: <201105131510.p4DFA76H009361@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157009
>Category: ports
>Synopsis: [patch] ftp/curl: respect DEBUG_FLAGS for CURL_DEBUG/TRACKMEMORY
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 15:10:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Pan Tsu
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Don't use vendor debug flags that cannot be overriden for options, this
was addresed by the original patch in ports/150854 but for some unknown
reason lost during conversion to patch-configure.
$flags_opt_yes is probably not affected, nothing in the port seems to
use --enable-optimize.
>How-To-Repeat:
$ env -i cc -g0 foo.c -o foo
$ env -i cc -g0 -g foo.c -o bar
$ md5 foo bar
MD5 (foo) = 9891c299a4d390da6977d7720a12d975
MD5 (bar) = e1d78fa8a93bdfec134ed319b9deeae0
# no symbols, non-stripped, non-optimized, with run-time debug info compiled in
$ export WITH_DEBUG= WITH_TRACKMEMORY= DEBUG_FLAGS=-g0
$ make -V CFLAGS
-pipe -g0
$ make
...
libtool: compile: cc -DHAVE_CONFIG_H -I../include/curl -I../include -I../include -I../lib -I../lib -DCURLDEBUG -DDEBUGBUILD -I/usr/include/openssl -pipe -g0 -g -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wcast-align -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wno-sign-conversion -Wvla -Wno-system-headers -MT http.lo -MD -MP -MF .deps/http.Tpo -c http.c -fPIC -DPIC -o http.o >/dev/null 2>&1
That extra `-g' flag makes preceding `-g0' useless.
>Fix:
--- a.diff begins here ---
Index: ftp/curl/files/patch-configure
===================================================================
RCS file: /a/.cvsup/ports/ftp/curl/files/patch-configure,v
retrieving revision 1.14
diff -u -p -r1.14 patch-configure
--- ftp/curl/files/patch-configure 19 Dec 2010 20:04:23 -0000 1.14
+++ ftp/curl/files/patch-configure 13 May 2011 13:50:43 -0000
@@ -11,8 +11,9 @@ Last-Update: 2010-12-19
@@ -14201,10 +14201,10 @@
flags_dbg_all="$flags_dbg_all -gdwarf-2"
flags_dbg_all="$flags_dbg_all -gvms"
- flags_dbg_yes="-g"
+- flags_dbg_yes="-g"
- flags_dbg_off="-g0"
++ flags_dbg_yes=""
+ flags_dbg_off=""
flags_opt_all="-O -O0 -O1 -O2 -O3 -Os"
flags_opt_yes="-O2"
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86hb8yir03.fsf>