Date: Sat, 28 Oct 2000 16:31:29 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: Josef Karthauser <joe@pavilion.net> Cc: Tony Finch <dot@dotat.at>, Matt Jacob <mjacob@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci isp_pci.c Message-ID: <Pine.LNX.4.21.0010281625250.6685-100000@zeppo.feral.com> In-Reply-To: <20001029002754.I64763@pavilion.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Gee- I'm sorry- I must have deleted the front end of this mail thread w/o noticing it. I take it I'm being criticised for the informality of the log message. Thanks for your opinion- I'll try and remember it in the future. If CVS were easier to use wrt modifying the commit message- I'd change it now (that is, if we had an adult source management system, this would be easy to fix in retrospect). I assume that this is all mostly a theoretical exercise since I don't recall seeing either of you offer anything substantive, or anything at all, in terms of improving the code in question. I'd love it if you could devote cycles improving the code and reviewing the substance - and sending critiques about *that*, instead of making nits about the commit messages- but I'll try and make sure the messages meet your approval as well. It seems to me that the comment about seeing a useful history implies that some of you are actually paying attention to this corner of the code, which, frankly, given how little feedback I get about it, is shocking. Ta, then... -matt > On Thu, Oct 26, 2000 at 03:31:47AM +0000, Tony Finch wrote: > > Matt Jacob <mjacob@FreeBSD.org> wrote: > > > > > > Whoops! Forgot to commit this when I committed the other (turnin on locks) > > > change. Sorry about that. > > > > It seems to me (based on my experience as an Apache core team member > > and as someone who likes to understand software by looking at how it > > evolved) that for the purposes of maintaining a useful history, > > cockups like this should be handled by using the same commit message > > when committing the missing file(s) as was used in the original > > commit. Apologies should be posted separately or as an extra note > > added to the original commit message, instead of replacing all useful > > information with "whoops, sorry". > > I agree. There's a further benefit to this. The only way to > determine what files were committed at the same time after the fact > (excluding the commit mail logs) is to use a heuristic based on > commit message, committer and fuzzy time of day. Please please > use an exact copy of the commit message where possible otherwise > the subsequent change will never be rolled into the first commit. > > Joe > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.21.0010281625250.6685-100000>