Date: Mon, 26 Nov 2007 13:50:06 +0800 From: Rong-En Fan <rafan@freebsd.org> To: Kip Macy <kip.macy@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Rong-En Fan <rafan@freebsd.org> Subject: Re: cvs commit: src/lib/libc/locale none.c Message-ID: <20071126055006.GW79877@svm.csie.ntu.edu.tw> In-Reply-To: <b1fa29170711252106n66e14ec9v109d4ea9b547f1b6@mail.gmail.com> References: <200711260329.lAQ3THeB074777@repoman.freebsd.org> <b1fa29170711252106n66e14ec9v109d4ea9b547f1b6@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--s3R87C3fwYeCSZ0b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 25, 2007 at 09:06:05PM -0800, Kip Macy wrote: > I'm confused. So we're going to permanently break compatibility for > any apps built on 6.3 to work on 6.2 because of a brief transgression > by ache? I'm sure I'm just slow and I'm missing something so maybe you > could fill me in. No the compatibility is okay as I removed the whole ctype fix for 6.x branch few days ago. This commit is to provide compatibility for binaries built between the two dates I mentioned below. At that time, __mb_sb_limit was exported and I hide it on 20071030. However, as the ctype fix introduces three more functions which are exported via libc, you can not run binaries built on 6.3 on 6.2. So I back out the whole ctype fix. As the fix exists in 6.x for about one month, it would be better to leave those new symbols exported in libc but the behavior is the same before the ctype fix. This commit, together with previous one, is to make users no need to rebuild their binaries that were built in the past month. The ctype behavior is the same as ache's fix (in 6.x, of course). Please blame me for all these ctype fix in 6.x and 7.x. Andrey fixes them in CURRENT, it's me who do the MFC. Regards, Rong-En Fan >=20 > -Kip >=20 >=20 > On Nov 25, 2007 7:29 PM, Rong-En Fan <rafan@freebsd.org> wrote: > > rafan 2007-11-26 03:29:17 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6_3) > > lib/libc/locale none.c > > Log: > > - Put __mb_sb_limit symbol back to libc to ease users' pain when upgr= ading > > their 6-STABLE system. This is necessary because we have this symbol > > exported between 20071025 and 20071030. Binaries built during that = perios > > will be broken after 602115. > > > > Requested by: many > > Approved by: re (kensmith) > > > > Revision Changes Path > > 1.13.2.2.2.1 +1 -0 src/lib/libc/locale/none.c > > --s3R87C3fwYeCSZ0b Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHSl6O144QkYb9jGgRAmfnAJ0f4vRedf8WnRqNzciHZKpdYpP3bACglfu5 B+qTq+twbdtXtVLMRAzx47Q= =3ZdE -----END PGP SIGNATURE----- --s3R87C3fwYeCSZ0b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071126055006.GW79877>