Date: Thu, 11 Sep 2008 02:59:30 -0700 (PDT) From: Jeremy Chadwick <koitsu@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/127297: Redefinition warnings in print/freetype2 Message-ID: <20080911095930.5A78617B81A@icarus.home.lan> Resent-Message-ID: <200809111020.m8BAK2qd075851@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 127297
>Category: ports
>Synopsis: Redefinition warnings in print/freetype2
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Sep 11 10:20:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 7.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD icarus.home.lan 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Wed Sep 10 04:27:41 PDT 2008 root@icarus.home.lan:/usr/obj/usr/src/sys/PDSMI_PLUS_amd64 amd64
>Description:
During the build of print/freetype2, a very large number of warnings
are emitted due to the re-definition of TT_CONFIG_OPTION_BYTECODE_INTERPRETER.
Example:
In file included from ./builds/unix/ftconfig.h:42,
from /usr/ports/print/freetype2/work/freetype-2.3.7/src/base/ftinit.c:41:
/usr/ports/print/freetype2/work/freetype-2.3.7/include/freetype/config/ftoption.h:462:1: warning: "TT_CONFIG_OPTION_BYTECODE_INTERPRETER" redefined
<command line>:4:1: warning: this is the location of the previous definition
The port Makefile is causing this situation due to a bug.
The pre-patch section comments out #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER in
include/freetype/config/ftoption.h (when WITHOUT_TTF_BYTECODE_ENABLED is not
defined by the user), but then earlier in the Makefile, it re-enables it:
.if !defined(WITHOUT_TTF_BYTECODE_ENABLED)
CFLAGS+= -DTT_CONFIG_OPTION_BYTECODE_INTERPRETER
.endif
The solution is to remove the CFLAGS+=-DTT_CONFIG_OPTION_BYTECODE_INTERPRETER
piece of the Makefile.
>How-To-Repeat:
Build print/freetype2 normally -- make sure you DO NOT have
WITHOUT_TTF_BYTECODE_ENABLED=yes anywhere
>Fix:
Below is the attached patch. I'd commit this myself, but we're in a
code freeze, and I also don't want to offend any of the gnome@ folks.
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/freetype2/Makefile,v
retrieving revision 1.82
diff -u -r1.82 Makefile
--- Makefile 2 Jul 2008 19:58:12 -0000 1.82
+++ Makefile 11 Sep 2008 09:47:00 -0000
@@ -32,10 +32,6 @@
CONFIGURE_ARGS= --disable-nls
CONFIGURE_WRKSRC= ${WRKSRC}/builds/unix
-.if !defined(WITHOUT_TTF_BYTECODE_ENABLED)
-CFLAGS+= -DTT_CONFIG_OPTION_BYTECODE_INTERPRETER
-.endif
-
.if defined(WITH_LCD_FILTERING)
CFLAGS+= -DFT_CONFIG_OPTION_SUBPIXEL_RENDERING
.endif
Assuming gnome@ gives the thumbs up, I can commit this. I've tested
it when using WITHOUT_TTF_BYTECODE_ENABLED=yes and without; the
REINPLACE_CMD part of pre-patch does the right thing altogether.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080911095930.5A78617B81A>