From owner-cvs-all  Fri Mar  2  0:17:28 2001
Delivered-To: cvs-all@freebsd.org
Received: from wint.itfs.nsk.su (wint.itfs.nsk.su [212.20.32.43])
	by hub.freebsd.org (Postfix) with ESMTP id 8A9AA37B718
	for <cvs-all@FreeBSD.ORG>; Fri,  2 Mar 2001 00:17:24 -0800 (PST)
	(envelope-from nnd@wint.itfs.nsk.su)
Received: (from nnd@localhost)
	by wint.itfs.nsk.su (8.11.3/8.11.1) id f228HMq00592;
	Fri, 2 Mar 2001 14:17:22 +0600 (NOVT)
	(envelope-from nnd)
Date: Fri, 2 Mar 2001 14:17:22 +0600 (NOVT)
Message-Id: <200103020817.f228HMq00592@wint.itfs.nsk.su>
From: nnd@mail.nsk.ru
To: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.bin/wall ttymsg.c wall.1 wall.c
In-Reply-To: <200103010543.f215hD097964@freefall.freebsd.org>
User-Agent: tin/1.5.8-20010221 ("Blue Water") (UNIX) (FreeBSD/5.0-CURRENT (i386))
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In article <200103010543.f215hD097964@freefall.freebsd.org> you wrote:
> 
>  Modified files:
>    usr.bin/wall         ttymsg.c wall.1 wall.c 
>  Log:
>  o Add support for wall -g.  This will send a message to all members of
>    a given group.
>  o Minor code style cleanups while I'm here
>  
>  Reviewed by: bde, kris, markm, audit@

	And there is still trivial error in the 'ttymsg.c'
after all that reviews ;-)

	You've change 

	(void) strcpy(device + sizeof(_PATH_DEV) - 1, line);

to

	strlcat(device, line, sizeof(device));
 
wich leads to the device's names of the "/dev/ttyv1ttyp0" kind
due to 'static char device[...' definition.

	N.Dudorov

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message