Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jul 2019 12:30:25 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 239159] emulators/wine-devel: build fails with STAGING option
Message-ID:  <bug-239159-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239159

            Bug ID: 239159
           Summary: emulators/wine-devel: build fails with STAGING option
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: gerald@FreeBSD.org
          Reporter: jcfyecrayz@liamekaens.com
          Assignee: gerald@FreeBSD.org
             Flags: maintainer-feedback?(gerald@FreeBSD.org)

Created attachment 205714
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205714&action=
=3Dedit
[patch] workaround for snwprintf undefined reference if STAGING=3Don

'make -C /usr/ports/emulators/wine-devel WITH=3DSTAGING' fails after the up=
date
to 4.12:

 .
 .
gcc8 -m64 -c -o classes.o classes.c -I. -I../../include -I../.. -D__WINESRC=
__
-D_SHELL32_ -D_REENTRANT -fPIC \
  -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-bo=
dy
-Wignored-qualifiers \
  -Wno-packed-not-aligned -Wshift-overflow=3D2 -Wstrict-prototypes -Wtype-l=
imits
\
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogica=
l-op
-isystem \
  /usr/local/include -O2 -pipe  -fstack-protector-strong
-Wl,-rpath=3D/usr/local/lib/gcc8 -isystem /usr/local/include -fno-strict-al=
iasing
/usr/local/bin/ld: dialog.o: in function `SetupPromptForDiskW':
dialog.c:(.text+0x10c0): undefined reference to `snwprintf'
collect2: error: ld returned 1 exit status
winegcc: gcc8 failed
gmake[3]: *** [Makefile:506: setupapi.dll.so] Error 2
gmake[3]: Leaving directory
'/d/local/users/jhein/.nobak/wd/usr/ports/emulators/wine-devel/work/wine-4.=
12/dlls/setupapi'


If you replace snwprintf with _snwprintf in the patched dialog.c (from the
staging patchset), the build succeeds:

--- dlls/setupapi/dialog.c.orig 2019-07-12 09:18:10.588254000 +0000
+++ dlls/setupapi/dialog.c      2019-07-12 11:32:31.303208000 +0000
@@ -249,7 +249,7 @@ UINT WINAPI SetupPromptForDiskW(HWND hwn

         if (lstrlenW(PathToSource) + 1 + lstrlenW(FileSought) <
sizeof(filepath))
         {
-            snwprintf(filepath, MAX_PATH, format, PathToSource, FileSought=
);
+            _snwprintf(filepath, MAX_PATH, format, PathToSource, FileSough=
t);

             if (GetFileAttributesW(filepath) !=3D INVALID_FILE_ATTRIBUTES)
             {

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-239159-7788>