Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Apr 2006 20:50:15 GMT
From:      Boris Samorodov <bsam@ipt.ru>
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/95424: update and unbreak net/ohphone, take maintainership
Message-ID:  <200604112050.k3BKoFQw073147@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/95424; it has been noted by GNATS.

From: Boris Samorodov <bsam@ipt.ru>
To: Joerg Pulz <Joerg.Pulz@frm2.tum.de>
Cc: bug-followup@freebsd.org
Subject: Re: ports/95424: update and unbreak net/ohphone, take maintainership
Date: Wed, 12 Apr 2006 00:44:47 +0400

 On Tue, 11 Apr 2006 21:43:51 +0200 (CEST) Joerg Pulz wrote:
 > On Tue, 11 Apr 2006, Boris Samorodov wrote:
 > > On Tue, 11 Apr 2006 19:42:02 +0200 (CEST) Joerg Pulz wrote:
 > >> On Tue, 11 Apr 2006, Boris Samorodov wrote:
 > >
 > >>> Great work, thanks!
 > >>>
 > >>> Patches applied cleanly, but:
 > >>>
 > >>> Minor errors at MASTER_SITE: remove double points and add trailing "/".
 > >>> The URL sould be
 > >>> ftp://ftp.frm2.tum.de/pub/jpulz/FreeBSD/distfiles/
 > >>>
 > >>> After fetching I can't build the port:
 > >>> -----
 > >>> ===>  Vulnerability check disabled, database not found
 > >>> ===>  Extracting for ohphone-1.4.5
 > >>> => MD5 Checksum OK for ohphone-1.4.5.tar.gz.
 > >>> => SHA256 Checksum OK for ohphone-1.4.5.tar.gz.
 > >>> ===>  Patching for ohphone-1.4.5
 > >>> ===>   ohphone-1.4.5 depends on executable: gmake - found
 > >>> ===>   ohphone-1.4.5 depends on executable: bison - found
 > >>> ===>   ohphone-1.4.5 depends on shared library: h323_r.1 - found
 > >>> ===>   ohphone-1.4.5 depends on shared library: X11.6 - found
 > >>> ===>  Configuring for ohphone-1.4.5
 > >>> ===>  Building for ohphone-1.4.5
 > >>> gmake P_SHAREDLIB=1 opt
 > >>> gmake[1]: Entering directory `/usr/ports/net/ohphone/work/ohphone-1.4.5'
 > >>> c++  -O1 -I/usr/ports/devel/pwlib/work/pwlib_v1_10_0/include -I/usr/local/include  -DP_USE_PRAGMA -D_REENTRANT -pthread -Wall  -I/usr/local/share/pwlib//include -DPTRACING -I/usr/local/include/openh323 -DHAS_X11 -I/usr/X11R6/include -Os  -O2 -fno-strict-aliasing -pipe  -O1 -I/usr/ports/devel/pwlib/work/pwlib_v1_10_0/include -I/usr/local/include  -felide-constructors -Wreorder -c main.cxx -o obj_r/main.o
 > >>> main.cxx: In member function `virtual BOOL MyH323EndPoint::OpenVideoChannel(H323Connection&, BOOL, H323VideoCodec&)':
 > >>> main.cxx:2071: error: `PSDLVideoDevice' has not been declared
 > >>> gmake[1]: *** [obj_r/main.o] Error 1
 > >>> gmake[1]: Leaving directory `/usr/ports/net/ohphone/work/ohphone-1.4.5'
 > >>> gmake: *** [optshared] Error 2
 > >>> *** Error code 2
 > >>>
 > >>> Stop in /usr/ports/net/ohphone.
 > >>> -----
 > >>>
 > >>> $ uname -a
 > >>> FreeBSD srv.sem.ipt.ru 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #0: Tue Mar  7 00:13:29 MSK 2006     bsam@srv.sem.ipt.ru:/usr/obj/usr/src/sys/SRV  i386
 > >
 > >> Hi Boris,
 > >
 > > Hi Joerg,
 > >> you are copletely right. The MASTER_SITE should really be
 > >> ftp://ftp.frm2.tum.de/pub/jpulz/FreeBSD/distfiles/
 > >
 > >> sorry for this mistake.
 > >
 > > It's OK. Thank you for the patch.
 > >
 > >> For your compile problem, can you please take a look in
 > >> ${LOCALBASE}/include/ptbuildopts.h line 470.
 > >> Does this line show a '#define P_SDL 0' or '#define P_SDL 1'.
 > >
 > > I have "#define P_SDL 0". Should it be 1? Should I reinstall some port
 > > with other options?
 > >
 > >> It seems that there is something wrong. Please make also sure that you
 > >> run 'make do-clean' in ${PORTSDIR}/devel/pwlib before trying to build
 > >> net/ohphone, as the ${WRKSRC}/include directory of devel/pwlib is part
 > >> of the include path when you try to build any ports which depend on
 > >> devel/pwlib which could lead to problems. This is a part which should
 > >> be fixed by the devel/pwlib port.
 > >
 > > I checked devel/pwlib port. It's clear.
 
 > "#define P_SDL 0" should be the problem as it really defines P_SDL and
 > the test in main.cxx of ohphone is "#ifdef P_SDL". So P_SDL is defined
 > to "0" and not undefined and the therefore "#ifdef P_SDL" is true but
 > should be wrong, as you have compiled devel/pwlib without SDL support.
 > A quick and easy way to fix this, is to edit line 470 of
 > ${LOCALBASE}/include/ptbuildopts.h and change it to "#undef
 > P_SDL". After that net/ohphone should compile just fine.
 
 Yes, you are right. The port compiles.
 
 > Another option is PR/95422 for devel/pwlib. Download and apply the
 > patch and rebuild/reinstall devel/pwlib with WITH_SDL=1 to force the
 > use of SDL. Afterwards net/ohphone should again compile cleanly and
 > you should be able to use SDL as video output device instead of x11
 > (x11 is still enabled and the default video output device).
 
 Confirm, that also helps.
 
 > In any case, devel/pwlib needs to be fixed for the case someone wants
 > to install it without SDL support.
 
 Sure.
 
 
 Thank you for quick and helful answers! The power to serve. ;-)
 
 
 WBR
 -- 
 Boris B. Samorodov, Research Engineer
 InPharmTech Co,     http://www.ipt.ru
 Telephone & Internet Service Provider



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604112050.k3BKoFQw073147>