Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2012 09:57:52 -0800
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@freebsd.org>
Subject:   Re: svn commit: r242842 - in head/sys: conf modules/mthca
Message-ID:  <CAGH67wRQBNA9V9D3whUVCF99jQEF2NC06D91KK%2BKHmJprxpEmg@mail.gmail.com>
In-Reply-To: <20121110191905.H915@besplex.bde.org>
References:  <201211100032.qAA0Wlvw090497@svn.freebsd.org> <20121110191905.H915@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 10, 2012 at 12:28 AM, Bruce Evans <brde@optusnet.com.au> wrote:

> On Sat, 10 Nov 2012, Xin LI wrote:
>
>  Log:
>>  Attempt toward a buildable universe by silenting a few warnings for OFED.
>>
>> Modified:
>>  head/sys/conf/kern.pre.mk
>>  head/sys/modules/mthca/**Makefile
>>
>
> Any chance of not adding style bugs in 1-line changes?
>
>
>  Modified: head/sys/conf/kern.pre.mk
>> ==============================**==============================**
>> ==================
>> --- head/sys/conf/kern.pre.mk   Fri Nov  9 21:41:07 2012        (r242841)
>> +++ head/sys/conf/kern.pre.mk   Sat Nov 10 00:32:47 2012        (r242842)
>> @@ -156,7 +156,7 @@ NORMAL_LINT=        ${LINT} ${LINTFLAGS} ${CFLA
>> # Infiniband C flags.  Correct include paths and omit errors that linux
>> # does not honor.
>> OFEDINCLUDES=   -I$S/ofed/include/
>> -OFEDNOERR=     -Wno-cast-qual -Wno-pointer-arith -fms-extensions
>> +OFEDNOERR=     -Wno-cast-qual -Wno-pointer-arith -fms-extensions
>> -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion
>> -Wno-initializer-overrides
>> OFEDCFLAGS=     ${CFLAGS:N-I*} ${OFEDINCLUDES} ${CFLAGS:M-I*} ${OFEDNOERR}
>> OFED_C_NOIMP=   ${CC} -c -o ${.TARGET} ${OFEDCFLAGS} ${WERROR} ${PROF}
>> OFED_C=         ${OFED_C_NOIMP} ${.IMPSRC}
>>
>
> Please don't format source files or output for 150-column terminals,
> especially when 'fixing' code formatted for 80 columns.
>
>
>  Modified: head/sys/modules/mthca/**Makefile
>> ==============================**==============================**
>> ==================
>> --- head/sys/modules/mthca/**Makefile     Fri Nov  9 21:41:07 2012
>>  (r242841)
>> +++ head/sys/modules/mthca/**Makefile     Sat Nov 10 00:32:47 2012
>>  (r242842)
>> @@ -28,4 +28,4 @@ opt_inet6.h:
>>
>> .include <bsd.kmod.mk>
>>
>> -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions
>> +CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions  -Wno-switch
>> -Wno-sometimes-uninitialized -Wno-conversion -Wno-initializer-overrides
>>
>
> This one also misformats the whitespace before the new set of options.
>
> Also, silencing warnings breaks them (unless they are bugs in clang).
> In normal development, it is just as easy to fix the bugs as to break the
> warnings, but there is a major compiler change lots of warnings are broken
> and then the bugs that they report tend to remain unfixed.  The compiler
> should not be changed if it causes a single new warning.
>

I agree if this commit was atomic and development was going to iterate on
from this point, but in reality cleaning up these items is going to require
a joint effort between the maintainers (currently listed as rwatson, but in
all actuality Isilon) and the upstream maintainters (the OFED group), etc
as this is (in part) contributed code. We're running 2 year old sources
that are going to be refreshed to a slightly newer version of the stack
soon, so Xin's silencing of the warnings is an ok approach (ultimately
those lines need to be clipped of the warnings anyhow, so this commit
should be reverted in the future).

I'll add this to a list of items that should be looked into internally and
resolved when moving to later versions of the stack (1.5.x latest/3.x).

Thanks!
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wRQBNA9V9D3whUVCF99jQEF2NC06D91KK%2BKHmJprxpEmg>