From owner-svn-src-head@FreeBSD.ORG Sat Nov 10 17:57:54 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 62F0EC5F; Sat, 10 Nov 2012 17:57:54 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E27C78FC08; Sat, 10 Nov 2012 17:57:53 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id wc20so6350388obb.13 for ; Sat, 10 Nov 2012 09:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HbLo5/tbgEIQbX2s5XdEfPAvJF6z1UebL+173Dzc6fM=; b=dYeZWwrmNgBhGtMaCVRRY+3AFTkB0XBl+wwactLusWaZdR++oYn8FX9JccITOip8U7 WcsG/tzkZHQiDJQuKdTqv7BdFY/da8KVzOtOiFGZyPh55ild7H/XRyayfcx53nY2Ayl+ 4ewbiv82VO7VVTSAhWoN0QvUlUpy+DcH5iFc7T0pzSBGtoxGh6kIZaGiy3fSbLtamCuQ 8bmZQuaxIgRubYuaqo9c9YGtXRKF2PW9WRF5ZC2ZC5Z5P577U/gdPr2LZlp4JVjvwejR h4GCV6h2uevCpOcrNHdywdM/Ujl8J7HKJOtHWUiRBAQWKKACl++dKj4uTxZcztoKds/X HzsQ== MIME-Version: 1.0 Received: by 10.60.28.42 with SMTP id y10mr10469871oeg.24.1352570273066; Sat, 10 Nov 2012 09:57:53 -0800 (PST) Received: by 10.76.143.33 with HTTP; Sat, 10 Nov 2012 09:57:52 -0800 (PST) In-Reply-To: <20121110191905.H915@besplex.bde.org> References: <201211100032.qAA0Wlvw090497@svn.freebsd.org> <20121110191905.H915@besplex.bde.org> Date: Sat, 10 Nov 2012 09:57:52 -0800 Message-ID: Subject: Re: svn commit: r242842 - in head/sys: conf modules/mthca From: Garrett Cooper To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2012 17:57:54 -0000 On Sat, Nov 10, 2012 at 12:28 AM, Bruce Evans wrote: > On Sat, 10 Nov 2012, Xin LI wrote: > > Log: >> Attempt toward a buildable universe by silenting a few warnings for OFED. >> >> Modified: >> head/sys/conf/kern.pre.mk >> head/sys/modules/mthca/**Makefile >> > > Any chance of not adding style bugs in 1-line changes? > > > Modified: head/sys/conf/kern.pre.mk >> ==============================**==============================** >> ================== >> --- head/sys/conf/kern.pre.mk Fri Nov 9 21:41:07 2012 (r242841) >> +++ head/sys/conf/kern.pre.mk Sat Nov 10 00:32:47 2012 (r242842) >> @@ -156,7 +156,7 @@ NORMAL_LINT= ${LINT} ${LINTFLAGS} ${CFLA >> # Infiniband C flags. Correct include paths and omit errors that linux >> # does not honor. >> OFEDINCLUDES= -I$S/ofed/include/ >> -OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions >> +OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions >> -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion >> -Wno-initializer-overrides >> OFEDCFLAGS= ${CFLAGS:N-I*} ${OFEDINCLUDES} ${CFLAGS:M-I*} ${OFEDNOERR} >> OFED_C_NOIMP= ${CC} -c -o ${.TARGET} ${OFEDCFLAGS} ${WERROR} ${PROF} >> OFED_C= ${OFED_C_NOIMP} ${.IMPSRC} >> > > Please don't format source files or output for 150-column terminals, > especially when 'fixing' code formatted for 80 columns. > > > Modified: head/sys/modules/mthca/**Makefile >> ==============================**==============================** >> ================== >> --- head/sys/modules/mthca/**Makefile Fri Nov 9 21:41:07 2012 >> (r242841) >> +++ head/sys/modules/mthca/**Makefile Sat Nov 10 00:32:47 2012 >> (r242842) >> @@ -28,4 +28,4 @@ opt_inet6.h: >> >> .include >> >> -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions >> +CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions -Wno-switch >> -Wno-sometimes-uninitialized -Wno-conversion -Wno-initializer-overrides >> > > This one also misformats the whitespace before the new set of options. > > Also, silencing warnings breaks them (unless they are bugs in clang). > In normal development, it is just as easy to fix the bugs as to break the > warnings, but there is a major compiler change lots of warnings are broken > and then the bugs that they report tend to remain unfixed. The compiler > should not be changed if it causes a single new warning. > I agree if this commit was atomic and development was going to iterate on from this point, but in reality cleaning up these items is going to require a joint effort between the maintainers (currently listed as rwatson, but in all actuality Isilon) and the upstream maintainters (the OFED group), etc as this is (in part) contributed code. We're running 2 year old sources that are going to be refreshed to a slightly newer version of the stack soon, so Xin's silencing of the warnings is an ok approach (ultimately those lines need to be clipped of the warnings anyhow, so this commit should be reverted in the future). I'll add this to a list of items that should be looked into internally and resolved when moving to later versions of the stack (1.5.x latest/3.x). Thanks! -Garrett