From owner-cvs-all@FreeBSD.ORG Wed Sep 27 18:10:17 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34F4316A407; Wed, 27 Sep 2006 18:10:17 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB75543D53; Wed, 27 Sep 2006 18:10:16 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k8RIAGlx022080; Wed, 27 Sep 2006 18:10:16 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k8RIAGSu022079; Wed, 27 Sep 2006 18:10:16 GMT (envelope-from alc) Message-Id: <200609271810.k8RIAGSu022079@repoman.freebsd.org> From: Alan Cox Date: Wed, 27 Sep 2006 18:10:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2006 18:10:17 -0000 alc 2006-09-27 18:10:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: MFC Correct a very old and very obscure bug: vmspace_fork() calls pmap_copy() if the mapping is VM_INHERIT_SHARE. Suppose the mapping is also wired. vmspace_fork() clears the wiring attributes in the vm map entry but pmap_copy() copies the PG_W attribute in the PTE. I don't think this is catastrophic. It blocks pmap_remove_pages() from destroying the mapping and corrupts the pmap's wiring count. This revision fixes the problem by changing pmap_copy() to clear the PG_W attribute. Approved by: re (mux) Revision Changes Path 1.516.2.8 +4 -3 src/sys/amd64/amd64/pmap.c 1.523.2.8 +5 -3 src/sys/i386/i386/pmap.c