Date: Wed, 26 Jul 2017 12:56:01 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Jose Alonso Cardenas Marquez <acm@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r446552 - head/devel/dcd-server Message-ID: <2e7717ee-de7e-9282-d55d-204f53004608@FreeBSD.org> In-Reply-To: <20170726105252.GC35824@FreeBSD.org> References: <201707250144.v6P1isvV008488@repo.freebsd.org> <d2532ad7-fe6a-11cb-eb25-8146f35ca5ba@FreeBSD.org> <20170726070112.GA35824@FreeBSD.org> <e5571e27-afda-2786-8f4a-5e0aba07c710@FreeBSD.org> <20170726103915.GB35824@FreeBSD.org> <c408fe59-8574-884c-3efb-4ff9ffcb0949@FreeBSD.org> <20170726105252.GC35824@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AnXBikGd21tfV1DCAT5wOn9Dqre46G0W3 Content-Type: multipart/mixed; boundary="81xsS5q5B6Wq3NxSbT5DoJL9sFSb29sBf"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Jose Alonso Cardenas Marquez <acm@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <2e7717ee-de7e-9282-d55d-204f53004608@FreeBSD.org> Subject: Re: svn commit: r446552 - head/devel/dcd-server References: <201707250144.v6P1isvV008488@repo.freebsd.org> <d2532ad7-fe6a-11cb-eb25-8146f35ca5ba@FreeBSD.org> <20170726070112.GA35824@FreeBSD.org> <e5571e27-afda-2786-8f4a-5e0aba07c710@FreeBSD.org> <20170726103915.GB35824@FreeBSD.org> <c408fe59-8574-884c-3efb-4ff9ffcb0949@FreeBSD.org> <20170726105252.GC35824@FreeBSD.org> In-Reply-To: <20170726105252.GC35824@FreeBSD.org> --81xsS5q5B6Wq3NxSbT5DoJL9sFSb29sBf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 26/07/2017 =C3=A0 12:52, Alexey Dokuchaev a =C3=A9crit : > On Wed, Jul 26, 2017 at 12:45:38PM +0200, Mathieu Arnold wrote: >> Le 26/07/2017 ?? 12:39, Alexey Dokuchaev a ??crit : >>> On Wed, Jul 26, 2017 at 12:22:45PM +0200, Mathieu Arnold wrote: >>>> Le 26/07/2017 ?? 09:01, Alexey Dokuchaev a ??crit : >>>>> On Wed, Jul 26, 2017 at 12:36:01AM +0200, Mathieu Arnold wrote: >>>>>> Le 25/07/2017 ?? 03:44, Jose Alonso Cardenas Marquez a ??crit : >>>>>>> New Revision: 446552 >>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/446552 >>>>>>> >>>>>>> Log: >>>>>>> - Add pkg-plist forgotten on previous commit >>>>>> You need to bump PORTREVISION so that the package is rebuilt with >>>>>> the plist. >>>>> Why would it get packaged without (with an empty) plist? >>>> What are metaports? >>> "Abstract" ports that don't install things on their own but pull a se= t of >>> dependencies? How's it relevant to `devel/dcd-server', unless I'm mi= ssing >>> something? >> I guess Jeopardy! is not that a universal thing. > ENOPARSE, sorry. > >> A port without a plist is perfectly valid, it will get build, and >> packaged just fine. The framework cannot know that you forgot to commi= t >> the plist. So if you commit a port and forget the plist, it will get >> built and the package will have dependencies, and no files. If you the= n >> add the plist later, the framework cannot know that the package it bui= lt >> earlier needs to be rebuilt because it has files now, so PORTREVISION >> needs to be bumped. > Shouldn't `check-plist' kick in and packaging fail due to untracked fil= es > being installed and plist forgotten? It surely does, but reality check: 1) not everybody checks that what they commit actually fetches, builds, packages, or installs. 2) it does not prevent foot shooting because you forgot to svn add the pkg-plist file before committing. --=20 Mathieu Arnold --81xsS5q5B6Wq3NxSbT5DoJL9sFSb29sBf-- --AnXBikGd21tfV1DCAT5wOn9Dqre46G0W3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZeHVCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I+6UQAJSvp6NENLCIFTZ2UbMflbJT DPX4AdqIxkR2BXyMvCLxzReqAQ7VHKrcXx1IfWZ3eW2Rk9fN3JF/9DAGnUsbS84E BobAUYQMCPU8QlRIQFGDbrh/jBNe3cX1wp22MfYnNWaqjfYFKzQ75a+p2oWxG+f1 5i/kJUQCVpWEBfmSHkIj1wHXFiEY4k1cCg3mMa15pMBry+dIQkhJsOEJoQaW+Umo SYmMfs+i1z+l59kVlmbsIr0D7OXOHE1zhoPEapRBPi4xlJOpTiwse9k81nxKkztO 8DcMx8NX5g5BzXsVfPGtVYAmoKKUJX4gD6cihJHluIFPLO5TW4aPxaOokSPPwj/u 2wBRo72WwcDXplMnj8vqvGeU2YqYPCWhuk48PDewqK+2OlX3sEQKdEZE75YHlvJl pkltZ1qwowODHbxdYD/wYWgMC0bp5SFLfvlVM7PmQy3orbRQqOdJeikWknUIsD3I RQ6Sa9rPRDcavku8/Gqr4Jc/QowbJkT80VGT1JsO/HD1MWEgxrDVa9NZsCpplRhx tIWkPcew4Q6T1deieZTRTdR4h6/CVWC5uGWhTi2hIGcViHgO+5wB++x4Mp5bDFRd /elOnXxcJfJvFzvaFvsZTbgyLz8JpbQL2WpYWl/jEcsaDhyX15PD87DZUHC6ov7z RfzkCI4s11TsibcE7+MI =Ui/f -----END PGP SIGNATURE----- --AnXBikGd21tfV1DCAT5wOn9Dqre46G0W3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2e7717ee-de7e-9282-d55d-204f53004608>