Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Nov 2012 08:27:12 +0000 (UTC)
From:      "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r307891 - in head/benchmarks/bonnie++: . files
Message-ID:  <20121129081330.M86834@FreeBSD.org>
In-Reply-To: <20121128092232.GA45503@FreeBSD.org>
References:  <201211280826.qAS8QmWu077786@svn.freebsd.org> <20121128092232.GA45503@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 28 Nov 2012 09:22:32 +0000, Alexey Dokuchaev wrote

Hi Alexey,

> I wonder is it about time to drop this $PTHREAD_LIBS magic?  
> It's been -pthread on all supported versions of FreeBSD for a 
> while now.

+1 for removing $PTHREAD_LIBS if it is not needed anymore.

> Not to mention that in this case actual patch 
> seems overly engineered and not particularly pretty (sorry 
> Ganael).

Oops, you're right, the patch is really ugly ; I could've simply used
REINPLACE_CMD here. I'll fix that (I presume I was too tired when I
worked on it ; thanks for having noticed that).

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129081330.M86834>