Date: Wed, 13 Sep 2017 10:47:23 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Cy Schubert <cy@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449703 - in head/graphics: xpdf xpdf4 Message-ID: <57f600ab-e484-7174-2789-ca010f402f12@FreeBSD.org> In-Reply-To: <201709121904.v8CJ4Ylv074168@repo.freebsd.org> References: <201709121904.v8CJ4Ylv074168@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mSWnV2Lnucm3ikSatJiaari9puPnXDUVR
Content-Type: multipart/mixed; boundary="pWV58FPDs983JJ91XbPcSNuJOFjtOdTUQ";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Cy Schubert <cy@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <57f600ab-e484-7174-2789-ca010f402f12@FreeBSD.org>
Subject: Re: svn commit: r449703 - in head/graphics: xpdf xpdf4
References: <201709121904.v8CJ4Ylv074168@repo.freebsd.org>
In-Reply-To: <201709121904.v8CJ4Ylv074168@repo.freebsd.org>
--pWV58FPDs983JJ91XbPcSNuJOFjtOdTUQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: fr
Le 12/09/2017 =C3=A0 21:04, Cy Schubert a =C3=A9crit=C2=A0:
> - ${LN} -sf ${PREFIX}/libexec/xpdf/xpdf ${STAGEDIR}${PREFIX}/bin/xpdf
> + @cd ${STAGEDIR}${PREFIX}; \
> + ${LN} -sf libexec/xpdf/xpdf bin/xpdf
> =20
>
> - ${LN} -sf ${PREFIX}/libexec/xpdf/xpdf ${STAGEDIR}${PREFIX}/bin/xpdf
> + @cd ${STAGEDIR}${PREFIX}; \
> + ${LN} -sf libexec/xpdf/xpdf bin/xpdf
> +
Good example of when not to use ${LN} because you will get it wrong.
(Hint, the new version you committed is wrong, the previous was bad but
working.)
Please read:
https://www.freebsd.org/doc/en/books/porters-handbook/special.html#stagin=
g-symlink
--=20
Mathieu Arnold
--pWV58FPDs983JJ91XbPcSNuJOFjtOdTUQ--
--mSWnV2Lnucm3ikSatJiaari9puPnXDUVR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJZuPCcXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ILLYP/1yexoarb7DxTYtt/Hh3r1NU
ayC8mOAampP5hxy6z8RwP4kJII5lU3egEcwu5RfMPdT8uCzA2DXhInC0ZbRKUZ1t
jHdCEKuICteSKUoVmusqPkIPcsg34oQW/ASJInh5MBIK3kc8HWv7grVzZXfGIBAM
eCj8c649SDGin62zXqZe/KV4OM2Cf71M69cCTUGYPBWg8dH71S6AUIlxdmefFevy
gNt47677dowbhiB8e8ISMoteG5dlPnNCaHV6esLW8J8HNt/ThCNqyFMj02kdelKC
3LTib5/YToIe5rs7hyQBgWm9LdZ5PdGiS3qfhMYmnqJNpSzvmqW7Y90wnzkkSj7p
t/XiI5w48BQbQO55KkCOw4c8kK+KFlMnr3e20Sqht1K7zaDk8weVPs+5ejPk+iUn
7j5zbeqlmvguyEXJlenaAZOfdFivoKcaD0RkQ41E+rIAwMiGVznLaYqXpBXe3nfB
/nZHvcfL9Wxq1+JwXyWu0KX1tzHULvAu6wsIliqPAx6opba1RnPAm9Jc/+kfM4DT
f5+2ocxgKvEzHjbjrQWS3wjQBdlwmZzH53cXfkbhn99IaBScoA5Zk+BCFgrwe6zk
yg3tNJs3OWSzlTf1Bam6dvkFVNmQK7bltZfWhp6y4z9Fl+TQM3uUSAj1oAyYTdFy
f1V2Ti77XO2jbZPLZSOq
=mZ02
-----END PGP SIGNATURE-----
--mSWnV2Lnucm3ikSatJiaari9puPnXDUVR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57f600ab-e484-7174-2789-ca010f402f12>