Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Sep 2002 20:37:13 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Marc Recht <marc@informatik.uni-bremen.de>
Cc:        current@FreeBSD.ORG
Subject:   Re: GEOM panic in current kernel 
Message-ID:  <33985.1033238233@critter.freebsd.dk>
In-Reply-To: Your message of "Sat, 28 Sep 2002 20:30:14 %2B0200." <20020928203014.64173e8b.marc@informatik.uni-bremen.de> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020928203014.64173e8b.marc@informatik.uni-bremen.de>, Marc Recht 
writes:
>--=./s+MTW'WA?QFc=
>Content-Type: text/plain; charset=US-ASCII
>Content-Transfer-Encoding: 7bit
>
>> >After the latest geom_* commits I get a panic while booting. The panic occurs before mounting the disks, so I had to hand-write it down..
>> >panic..
>> >mtx_init(e0499ce8, e0396b85, 0, 0, 748f6273) at mtx_init + 0x5f
>> >... g_up_procbody + 0x34
>> >...
>Wow! That was a fast reply. :-)
> 
>> Uhm, what was the actual panic message ?
>mutex g_up 0xe0499cb8 already initialized
>

Can you try this patch ?

Index: geom_kern.c
===================================================================
RCS file: /home/ncvs/src/sys/geom/geom_kern.c,v
retrieving revision 1.7
diff -u -r1.7 geom_kern.c
--- geom_kern.c	28 Sep 2002 11:57:20 -0000	1.7
+++ geom_kern.c	28 Sep 2002 18:37:01 -0000
@@ -83,6 +83,7 @@
 	struct thread *tp = FIRST_THREAD_IN_PROC(p);
 	struct mtx mymutex;
 
+	bzero(&mymutex, sizeof mymutex);
 	mtx_init(&mymutex, "g_up", MTX_DEF, 0);
 	mtx_lock(&mymutex);
 	tp->td_base_pri = PRIBIO;
@@ -107,6 +108,7 @@
 	struct thread *tp = FIRST_THREAD_IN_PROC(p);
 	struct mtx mymutex;
 
+	bzero(&mymutex, sizeof mymutex);
 	mtx_init(&mymutex, "g_down", MTX_DEF, 0);
 	mtx_lock(&mymutex);
 	tp->td_base_pri = PRIBIO;
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33985.1033238233>