From owner-freebsd-alpha Thu Jan 25 10:56:35 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 9CC3C37B6B0 for ; Thu, 25 Jan 2001 10:56:16 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0PIu5x30864; Thu, 25 Jan 2001 10:56:05 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f0PItdW00632; Thu, 25 Jan 2001 10:55:39 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <14959.33141.988328.39242@grasshopper.cs.duke.edu> Date: Thu, 25 Jan 2001 10:55:39 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Andrew Gallatin Subject: RE: cvs commit: src/sys/i386/i386 exception.s src/sys/kern kern_ Cc: alpha@FreeBSD.ORG Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 25-Jan-01 Andrew Gallatin wrote: > > John Baldwin writes: > > > > On 24-Jan-01 John Baldwin wrote: > > > jhb 2001/01/24 13:59:25 PST > > > > > > Modified files: > > > sys/i386/i386 exception.s > > > sys/kern kern_fork.c > > > sys/sys proc.h > > > sys/alpha/alpha swtch.s trap.c vm_machdep.c > > > Log: > > > - Change fork_exit() to take a pointer to a trapframe as its 3rd > argument > > > instead of a trapframe directly. (Requested by bde.) > > > - Convert the alpha switch_trampoline to call fork_exit() and use the > MI > > > fork_return() instead of child_return(). > > > - Axe child_return(). > > > > This should fix Drew's WITNESS panic as the mutex release of sched_lock > > by a forked child will be noticed by WITNESS now. > > Bingo. I'm now booting a WITNESS kernel. Thanks for fixing this so > quickly! Actually, the fix was accidental, the real motivation was using the new MI fork return code on the alpha. :) > One last thing to point out -- when amd starts, I see this: > > lock order reversal > 1st vnode interlock last acquired @ ../../kern/vfs_vnops.c:644 > 2nd 0xfffffc000074d030 mntvnode @ ../../ufs/ffs/ffs_vfsops.c:940 > 3rd 0xfffffe0006a774c0 vnode interlock @ ../../ufs/ffs/ffs_vfsops.c:949 This is a problem that was present in the old VFS code with simplelocks, we just haven't had tools to see this until now. It doesn't hurt anything at the moment. > But it keeps on booting. I'm running a fairly old world, so there may > be some sort of kernel / userland sync issue.. > > Drew -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message