Date: Tue, 20 Oct 2015 07:21:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bartek Rutkowski <robak@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r373471 - in head/editors/sublime3: . files Message-ID: <20151020072144.GA85130@FreeBSD.org> In-Reply-To: <20141127084320.GA28314@FreeBSD.org> References: <201411262346.sAQNkcjt044067@svn.freebsd.org> <20141127084320.GA28314@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 27, 2014 at 08:43:20AM +0000, Alexey Dokuchaev wrote: > Hi, > > Few observations, if you allow... > > On Wed, Nov 26, 2014 at 11:46:38PM +0000, Bartek Rutkowski wrote: > > New Revision: 373471 > > URL: https://svnweb.freebsd.org/changeset/ports/373471 > > QAT: https://qat.redports.org/buildarchive/r373471/ > > > [...] > > > +%%DATADIR%%/sublime_text $* > > $* is wrong, should be "$@" (yes, with quotes). Otherwise it won't handle > parameters with spaces etc. correctly. It took us little less than one year to fix a small bug (see r399802). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151020072144.GA85130>