Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Sep 2013 21:35:53 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r328251 - in head/audio/pianobar: . files
Message-ID:  <20130930213552.GA4592@FreeBSD.org>
In-Reply-To: <20130927115344.GF89479@hades.panopticon>
References:  <201309250418.r8P4I80F089239@svn.freebsd.org> <20130925065903.GA14934@FreeBSD.org> <20130925130916.GD89479@hades.panopticon> <20130927081944.GA5206@FreeBSD.org> <20130927115344.GF89479@hades.panopticon>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 27, 2013 at 03:53:44PM +0400, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe@FreeBSD.org) wrote:
> > > That does not matter.
> > 
> > Technically it does not, but as I said, it's better to have them still.
> 
> For which reason?

Quoting someone, perhaps Michael Scherbakov, "and if one needs an
explanation, there is really nothing to explain".  ;-)

> > > There were none, see PR.
> > 
> > So why the header change was comitted then?
> 
> Because it was in the PR.

Submitters can make mistakes at times; that's why we need committers: so
crap from the PR remains in the PR, not in the repo.  Noise-only changes
should not be committed without sufficient reason.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130930213552.GA4592>