From owner-svn-ports-head@FreeBSD.ORG  Mon Sep 30 21:35:53 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 13F38EDD; Mon, 30 Sep 2013 21:35:53 +0000 (UTC)
Date: Mon, 30 Sep 2013 21:35:53 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Dmitry Marakasov <amdmi3@amdmi3.ru>
Subject: Re: svn commit: r328251 - in head/audio/pianobar: . files
Message-ID: <20130930213552.GA4592@FreeBSD.org>
References: <201309250418.r8P4I80F089239@svn.freebsd.org>
 <20130925065903.GA14934@FreeBSD.org>
 <20130925130916.GD89479@hades.panopticon>
 <20130927081944.GA5206@FreeBSD.org>
 <20130927115344.GF89479@hades.panopticon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130927115344.GF89479@hades.panopticon>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Sep 2013 21:35:53 -0000

On Fri, Sep 27, 2013 at 03:53:44PM +0400, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe@FreeBSD.org) wrote:
> > > That does not matter.
> > 
> > Technically it does not, but as I said, it's better to have them still.
> 
> For which reason?

Quoting someone, perhaps Michael Scherbakov, "and if one needs an
explanation, there is really nothing to explain".  ;-)

> > > There were none, see PR.
> > 
> > So why the header change was comitted then?
> 
> Because it was in the PR.

Submitters can make mistakes at times; that's why we need committers: so
crap from the PR remains in the PR, not in the repo.  Noise-only changes
should not be committed without sufficient reason.

./danfe