Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 7 Dec 2015 05:59:24 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r291922 - head/sys/dev/sfxge/common
Message-ID:  <201512070559.tB75xOcV015402@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: arybchik
Date: Mon Dec  7 05:59:24 2015
New Revision: 291922
URL: https://svnweb.freebsd.org/changeset/base/291922

Log:
  sfxge: support PERMIT_SET_MAC_WHEN_FILTERS_INSTALLED flag
  
  Use flag on vadapter alloc when reported as a supported capability.
  Use the slow device reset only when the capability is missing.
  
  Submitted by:   Richard Houldsworth <rhouldsworth at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      2 days
  Differential Revision: https://reviews.freebsd.org/D4387

Modified:
  head/sys/dev/sfxge/common/efx.h
  head/sys/dev/sfxge/common/hunt_nic.c
  head/sys/dev/sfxge/common/siena_nic.c

Modified: head/sys/dev/sfxge/common/efx.h
==============================================================================
--- head/sys/dev/sfxge/common/efx.h	Mon Dec  7 05:13:29 2015	(r291921)
+++ head/sys/dev/sfxge/common/efx.h	Mon Dec  7 05:59:24 2015	(r291922)
@@ -1173,6 +1173,7 @@ typedef struct efx_nic_cfg_s {
 	/* Datapath firmware vadapter/vport/vswitch support */
 	boolean_t		enc_datapath_cap_evb;
 	boolean_t               enc_rx_disable_scatter_supported;
+	boolean_t               enc_allow_set_mac_with_installed_filters;
 	/* External port identifier */
 	uint8_t			enc_external_port;
 } efx_nic_cfg_t;

Modified: head/sys/dev/sfxge/common/hunt_nic.c
==============================================================================
--- head/sys/dev/sfxge/common/hunt_nic.c	Mon Dec  7 05:13:29 2015	(r291921)
+++ head/sys/dev/sfxge/common/hunt_nic.c	Mon Dec  7 05:59:24 2015	(r291922)
@@ -149,6 +149,9 @@ efx_mcdi_vadaptor_alloc(
 	req.emr_out_length = MC_CMD_VADAPTOR_ALLOC_OUT_LEN;
 
 	MCDI_IN_SET_DWORD(req, VADAPTOR_ALLOC_IN_UPSTREAM_PORT_ID, port_id);
+	MCDI_IN_POPULATE_DWORD_1(req, VADAPTOR_ALLOC_IN_FLAGS,
+	    VADAPTOR_ALLOC_IN_FLAG_PERMIT_SET_MAC_WHEN_FILTERS_INSTALLED,
+	    enp->en_nic_cfg.enc_allow_set_mac_with_installed_filters ? 1 : 0);
 
 	efx_mcdi_execute(enp, &req);
 
@@ -928,6 +931,15 @@ hunt_get_datapath_caps(
 		encp->enc_rx_disable_scatter_supported = B_FALSE;
 	}
 
+	/* Check if the firmware supports set mac with running filters */
+	if (MCDI_CMD_DWORD_FIELD(&datapath_capabilities,
+	    GET_CAPABILITIES_OUT_VADAPTOR_PERMIT_SET_MAC_WHEN_FILTERS_INSTALLED)
+	    == 1) {
+		encp->enc_allow_set_mac_with_installed_filters = B_TRUE;
+	} else {
+		encp->enc_allow_set_mac_with_installed_filters = B_FALSE;
+	}
+
 	return (0);
 
 fail2:

Modified: head/sys/dev/sfxge/common/siena_nic.c
==============================================================================
--- head/sys/dev/sfxge/common/siena_nic.c	Mon Dec  7 05:13:29 2015	(r291921)
+++ head/sys/dev/sfxge/common/siena_nic.c	Mon Dec  7 05:59:24 2015	(r291922)
@@ -170,6 +170,7 @@ siena_board_cfg(
 
 	encp->enc_hw_tx_insert_vlan_enabled = B_FALSE;
 	encp->enc_fw_assisted_tso_enabled = B_FALSE;
+	encp->enc_allow_set_mac_with_installed_filters = B_TRUE;
 
 	return (0);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512070559.tB75xOcV015402>