Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Jul 2018 21:12:01 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Andrew Gallatin <gallatin@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r335973 - head/sys/dev/mxge
Message-ID:  <201807050412.w654C1IO046149@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201807050243.w652hAYL018215@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: gallatin
> Date: Thu Jul  5 02:43:10 2018
> New Revision: 335973
> URL: https://svnweb.freebsd.org/changeset/base/335973
> 
> Log:
>   mxge: replace 65536 with IP_MAXPACKET in tso settings.
> 

Thank you, I see some of the oddities in tso for
other cards but I think there are card limitations
occuring there that are at issue.


> Modified:
>   head/sys/dev/mxge/if_mxge.c
> 
> Modified: head/sys/dev/mxge/if_mxge.c
> ==============================================================================
> --- head/sys/dev/mxge/if_mxge.c	Thu Jul  5 02:08:57 2018	(r335972)
> +++ head/sys/dev/mxge/if_mxge.c	Thu Jul  5 02:43:10 2018	(r335973)
> @@ -4984,9 +4984,9 @@ mxge_attach(device_t dev)
>  	ifp->if_ioctl = mxge_ioctl;
>  	ifp->if_start = mxge_start;
>  	ifp->if_get_counter = mxge_get_counter;
> -	ifp->if_hw_tsomax = 65536 - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN);
> +	ifp->if_hw_tsomax = IP_MAXPACKET - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN);
>  	ifp->if_hw_tsomaxsegcount = sc->ss[0].tx.max_desc;
> -	ifp->if_hw_tsomaxsegsize = 65536;
> +	ifp->if_hw_tsomaxsegsize = IP_MAXPACKET;
>  	/* Initialise the ifmedia structure */
>  	ifmedia_init(&sc->media, 0, mxge_media_change,
>  		     mxge_media_status);
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807050412.w654C1IO046149>