From owner-cvs-all@FreeBSD.ORG  Wed Jun  4 19:55:02 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 639BF1065673;
	Wed,  4 Jun 2008 19:55:02 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 11D328FC20;
	Wed,  4 Jun 2008 19:55:01 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from [192.168.0.40] ([204.244.149.125]) (authenticated bits=0)
	by sippysoft.com (8.13.8/8.13.8) with ESMTP id m54JsudE000513
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 4 Jun 2008 12:54:58 -0700 (PDT)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <4846F30A.5070204@FreeBSD.org>
Date: Wed, 04 Jun 2008 12:54:50 -0700
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Remko Lodder <remko@FreeBSD.org>
References: <200805301426.m4UEQ92d025434@repoman.freebsd.org>
	<48405C4B.3050603@FreeBSD.org> <1212179252.1967.1.camel@localhost>
	<a01628140806030818te29e2fet287d59f5ceedfc9c@mail.gmail.com>
	<20080604041815.GA84027@FreeBSD.org>
	<20080604043955.GA38627@troutmask.apl.washington.edu>
	<20080604063631.GA28351@freebie.xs4all.nl>
	<20080604150013.GA44358@troutmask.apl.washington.edu>
	<20080604191339.GA31570@freebie.xs4all.nl>
	<20080604192955.GA46284@troutmask.apl.washington.edu>
	<4846EF10.1020803@FreeBSD.org>
In-Reply-To: <4846EF10.1020803@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, src-committers@FreeBSD.org,
	Florent Thoumie <flz@FreeBSD.org>, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, Steve Kargl <sgk@troutmask.apl.washington.edu>,
	Wilko Bulte <wb@freebie.xs4all.nl>, Coleman Kane <cokane@FreeBSD.org>
Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c pkg_add.1
 src/usr.sbin/pkg_install/create
 main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c pkg_delete.1
 src/usr.sbin/pkg_install/info main.c pkg_info.1 ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jun 2008 19:55:02 -0000

Remko Lodder wrote:
>> Where do we stop?  Should we add long options to all
>> /usr/bin utilities?  Why stop at /usr/bin, let's add
>> long options to /usr/sbin, /bin, /sbin, /rescue, etc.
>>
> 
> That is not your call. If a maintainer wants to add all options he can 
> consider, he is free to do so. Though others might not appreciate that 
> as much as he does. It can be discussed ofcourse, but to a certain extend.

It's not your call either. We have style(9), which says:

      For consistency, getopt(3) should be used to parse options.  Options
      should be sorted in the getopt(3) call and the switch statement, 
unless
      parts of the switch cascade.  Elements in a switch statement that 
cascade
      should have a FALLTHROUGH comment.  Numerical arguments should be 
checked
      for accuracy.  Code that cannot be reached should have a 
NOTREACHED com-
      ment.

There is nothing about getopt_long(3) being acceptable 
replacement/addition to the getopt(3).

-Maxim