Date: Tue, 11 Aug 1998 13:12:06 -0400 (EDT) From: Brian Feldman <green@zone.syracuse.NET> To: Luoqi Chen <luoqi@watermarkgroup.com> Cc: archer@lucky.net, bde@zeta.org.au, current@FreeBSD.ORG Subject: Re: New softupdates code panics Message-ID: <Pine.BSF.4.02.9808111310260.461-100000@zone.syracuse.NET> In-Reply-To: <199808111412.KAA27035@lor.watermarkgroup.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I think I understand here, you meant the association of the code would be (doingdirectory && newparent) ? newparent : doingdirectory rather that doingdirectory && (newparent ? newparent : doingdirectory) correct? And that would have been what led to the confusion. Cheers, Brian Feldman On Tue, 11 Aug 1998, Luoqi Chen wrote: > > >> The same here. My system paniced two times for some 4 hours after > > >> I've booted kernel with Kirk's patches. The system was not very > > >> busy, just ordinary mail/news reception (it is home computer). > > >> > > >Change the expression ``newparent ? newparent : doingdirectory'' in Kirk's > > >patch to ``doingdirectory && newparent ? newparent : doingdirectory''. > > >(for file ufs/ufs/ufs_vnops.c) > > > > Um, this expression is equivalent to ``doingdirectory'', which is the > > same as the unpatched expression. General fuzzy reasoning suggests that > > the expression should be ``doingdirectory && !newparent''. > > > > Bruce > > > newparent is not a boolean, and neither is the expression, they are integers. > The expression used to be boolean, but now we want it to have three states: > 0, 1, and >1, with the third state be doingdirectory && newparent. You could > write the expression as ``doingdirectory && newparent ? 2 : doingdirectory''. > > -lq > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.02.9808111310260.461-100000>