Date: Thu, 6 Sep 2001 10:11:22 +0930 From: Greg Lehey <grog@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Bruce Evans <bde@zeta.org.au>, Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include/arpa tftp.h Message-ID: <20010906101122.O4447@wantadilla.lemis.com> In-Reply-To: <20010905084549.A95963@dragon.nuxi.com>; from obrien@FreeBSD.org on Wed, Sep 05, 2001 at 08:45:49AM -0700 References: <20010904185643.A78975@dragon.nuxi.com> <20010905203608.K22645-100000@alphplex.bde.org> <20010905084549.A95963@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, 5 September 2001 at 8:45:49 -0700, David O'Brien wrote:
> On Wed, Sep 05, 2001 at 08:39:34PM +1000, Bruce Evans wrote:
>>>>> Log:
>>>>> style(9) the structure definitions.
>>>> Was this *really* necessary?
>>>> I thought we had a policy against doing broad sweeps of
>>>> non-substantive changes like this.
>>>
>>> Yes it was -- we were so confused (partically do to your commit to
>>> style.9) that one could not figure out what was right. Now enough of the
>>> key places to look for style guidlines have been fixed. I don't plan on
>>> sweaping any more of the tree to just fix this.
>>
>> The existence of both in old code means that they were both right.
>
> The CSRG people can make mistakes too -- just like we do.
A lot of our current style is based on mistakes.
>> "struct\t.*{" does seem to be the least normal form although it is used
>> in the oldest code (proc.h...), but you shouldn't have changed it while
>> we are still discussing this.
>
> What more was there to discuss?
>
> This issue is one that is pretty easy to decide based on facts. When
> there is a 3:1 ratio of <space> to <tab> in our own code (and as you
> pointed out most of those were <tab> due to makesyscalls.sh. (the ratio
> was higher in the CSRG code).
Wouldn't it be nice if our algorithms were as pretty as our "style"?
Greg
--
See complete headers for address and phone numbers
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010906101122.O4447>