From owner-cvs-all@FreeBSD.ORG Wed Jun 21 18:14:05 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CCD616A484; Wed, 21 Jun 2006 18:14:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63E1E43D45; Wed, 21 Jun 2006 18:14:04 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5LIDUKd040406; Wed, 21 Jun 2006 14:13:59 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John-Mark Gurney Date: Wed, 21 Jun 2006 14:13:23 -0400 User-Agent: KMail/1.9.1 References: <200606211259.k5LCx5as082227@repoman.freebsd.org> <44998562.6080705@cs.rice.edu> <20060621175821.GB82074@funkthat.com> In-Reply-To: <20060621175821.GB82074@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606211413.24602.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 21 Jun 2006 14:13:59 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1559/Wed Jun 21 10:23:13 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Konstantin Belousov , src-committers@freebsd.org, Alan Cox , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/sys mincore.2 src/sys/vm vm_mmap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2006 18:14:05 -0000 On Wednesday 21 June 2006 13:58, John-Mark Gurney wrote: > Alan Cox wrote this message on Wed, Jun 21, 2006 at 12:44 -0500: > > John-Mark Gurney wrote: > > > > >Konstantin Belousov wrote this message on Wed, Jun 21, 2006 at 12:59 +0000: > > > > > >> Modified files: > > >> lib/libc/sys mincore.2 > > >> sys/vm vm_mmap.c > > >> Log: > > >> Make the mincore(2) return ENOMEM when requested range is not fully > > >> mapped. > > > > > >Is this change to be posix compliant or something? ENOMEM seems like > > >the wrong error, or are we allocating memory? > > >#define ENOMEM 12 /* Cannot allocate memory */ > > > > > >the original EINVAL seems to me the correct one, as is commonly used > > >when the data passed in is incorrect... > > > > I looked at this when the patch was proposed. ENOMEM is the de facto > > standard error for this case. To the best of my knowledge, there is no > > officially-sanctioned specification for mincore(2). > > Could you please provide a reference to this de facto standard error > as in other places where ENOMEM is used for such an error? NetBSD and Linux were the examples given on the thread in hackers@. Check the archives. -- John Baldwin