From owner-freebsd-bugs@freebsd.org Wed May 10 19:23:09 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F161BD67D22 for ; Wed, 10 May 2017 19:23:09 +0000 (UTC) (envelope-from amber.benson@leadsfortech.com) Received: from mail-it0-x246.google.com (mail-it0-x246.google.com [IPv6:2607:f8b0:4001:c0b::246]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BAAD8E3D for ; Wed, 10 May 2017 19:23:09 +0000 (UTC) (envelope-from amber.benson@leadsfortech.com) Received: by mail-it0-x246.google.com with SMTP id m128so7036760ita.15 for ; Wed, 10 May 2017 12:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadsfortech-com.20150623.gappssmtp.com; s=20150623; h=mime-version:message-id:date:subject:from:to; bh=hHWIQ1TRHwDwvsWpof+36tf+Ouqqr56Fpbcjj4qzeDo=; b=YGil1IMtxj0whwGc+Mdp/2ovxXWMUmHU03uFWveW8s06bTnjtwX9fpxRfWm82yZsl+ Xwtg31iOomcsX2iOZ3abvX1IrLwM2MPxdW6kAy9Kx7/xe8rRMaL59JK2CHldxTBpA5YZ mcdzy25Btrz89IsLAVp5vOFCM4G7bUjXTtLOCWjXguxms6gQEOtdARodcWWnYeF4DxKL pENphqfvZq0fTO+bmW1YD3Bj4b9vYB5FI3TpZg28AljGOuHf3vK95NU4exoQTFF6eIpp 6evnn8WPf2pZ69h8z+iAgHp+1KLNYWtmxSa+H7upEDs1dc1Bna4o4f2xROn41rsVbCJp WYIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:message-id:date:subject:from:to; bh=hHWIQ1TRHwDwvsWpof+36tf+Ouqqr56Fpbcjj4qzeDo=; b=lVcU3GoB5z8dPX24b8f75HeGE7EcT8koh+tVZ1InO6fOQY09KeKxNrY2IwYxzZwhC1 GIO4tGwQdNT2VeJ3KEeEdFWa+fcuMN/3dVzmVlbMinzK0DPKp3YafS4Iz8d1GDMpizP0 1mshVNTx+CVd+zfP55ixnvGCOB/oE/kjOFpDBJ6wf2KsFDRrAzOhbli6ujqUG41NVfdO IVTDbQp8rJ8iY9BypByWKsDsEQM7WtBCwcKtrOUhyCaZOUS8Zw12DfAj0fjG7JNfBzCL W2Uemc8TkJOldcm2BFTPpN0QV6mooBvZ4j5F8NHjs1+wwWefK7nMCOE/m6Ea1TwL7/dh HSlQ== X-Gm-Message-State: AODbwcCx1jKNYU5VjQoQ5aAJfS8FnmmeR0YtesWyXp8GUim4tPX5+2cZ nbWX8yVuQ8TIFyd/7cwB78Y9SY0XfQ== MIME-Version: 1.0 X-Received: by 10.36.26.76 with SMTP id 73mr3120479iti.26.1494444189128; Wed, 10 May 2017 12:23:09 -0700 (PDT) Message-ID: <001a1144529607a775054f30675b@google.com> Date: Wed, 10 May 2017 19:23:09 +0000 Subject: Avaya Users From: amber.benson@leadsfortech.com To: freebsd-bugs@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 19:23:10 -0000 PGRpdiBkaXI9Imx0ciI+PGRpdiBkaXI9Imx0ciI+PGRpdiBkaXI9Imx0ciI+PGRpdj48ZGl2ICAN CnN0eWxlPSJkaXNwbGF5OmlubGluZSI+PGRpdiAgDQppZD0ibV8tMzU0Nzc1MTIzMjgyOTU2Nzg2 OGdtYWlsLWRpdnRhZ2RlZmF1bHR3cmFwcGVyIj48ZGl2IGRpcj0ibHRyIj48cCAgDQpjbGFzcz0i TXNvTm9ybWFsIj48c3BhbiAgDQpzdHlsZT0iY29sb3I6cmdiKDMxLDc4LDEyMSk7Zm9udC1mYW1p bHk6Y2FsaWJyaSxhcmlhbCxoZWx2ZXRpY2Esc2Fucy1zZXJpZjtmb250LXNpemU6MTJwdCI+SGk8 L3NwYW4+PGZvbnQgIA0KY29sb3I9IiMxZjRlNzkiIGZhY2U9ImNhbGlicmksIGFyaWFsLCBoZWx2 ZXRpY2EsIHNhbnMtc2VyaWYiPjxzcGFuICANCnN0eWxlPSJmb250LXNpemU6MTZweCI+PC9zcGFu PjwvZm9udD48c3BhbiAgDQpzdHlsZT0iY29sb3I6cmdiKDMxLDc4LDEyMSk7Zm9udC1mYW1pbHk6 Y2FsaWJyaSxhcmlhbCxoZWx2ZXRpY2Esc2Fucy1zZXJpZjtmb250LXNpemU6MTJwdCI+LDwvc3Bh bj48L3A+PHAgIA0KY2xhc3M9Ik1zb05vcm1hbCIgIA0Kc3R5bGU9ImNvbG9yOnJnYigwLDAsMCk7 Zm9udC1mYW1pbHk6Y2FsaWJyaSxhcmlhbCxoZWx2ZXRpY2Esc2Fucy1zZXJpZjtmb250LXNpemU6 MTJwdCI+PHNwYW4gIA0Kc3R5bGU9ImNvbG9yOnJnYigzMSw3OCwxMjEpIj48YnI+V291bGQgeW91 IGJlIGludGVyZXN0ZWQgaW4NCjxiPkF2YXlhIFVzZXJzPC9iPiBjb250YWN0DQpsaXN0Pzxicj48 YnI+PGI+PHU+SW5mb3JtYXRpb24NCkZpZWxkczwvdT48L2I+wqDigJMgTmFtZSwNClRpdGxlLCBF bWFpbCwgUGhvbmUgTnVtYmVycywgQ29tcGFueSBOYW1lLCBhbmQgQ29tcGFueSBEZXRhaWxzIGxp a2UgUGh5c2ljYWwNCkFkZHJlc3MsIFdlYiBBZGRyZXNzLCBSZXZlbnVlIFNpemUsIEVtcGxveWVl IFNpemUgYW5kDQppbmR1c3RyeS4uPGJyPjxicj48Yj48dT5XZSBhbHNvIHByb3ZpZGUgb3RoZXIg cmVsYXRlZA0KVGVjaG5vbG9neSBVc2VycyBsaWtlPC91PjwvYj46IFBvbHljb20sIE5vcnRlbA0K TmV0d29ya3MsIEFydWJhIE5ldHdvcmtzLCBTaG9yZVRlbCwgSnVuaXBlciBOZXR3b3JrcywgQVQm YW1wO1QsIENpdHJpeCAgDQpTeXN0ZW1zLA0KTHluYyBTZXJ2ZXIsIFJpdmVyYmVkLCBGNSBOZXR3 b3JrcywgQXJpc3RhIE5ldHdvcmtzLCBCcm9jYWRlIEFuZCBNYW55DQpNb3JlLi4uPGJyPjxicj5Q bGVhc2UgcmV2aWV3IGFuZCBsZXQgbWUga25vdyBpZiB5b3UNCmFyZSBpbnRlcmVzdGVkIGFuZCBJ IHdpbGwgZ2V0IGJhY2sgdG8geW91IHdpdGggbW9yZSBpbmZvcm1hdGlvbiBmb3IgdGhlDQpzYW1l Ljxicj48YnI+VGhhbmtzLDxicj48Yj5BbWJlciBCZW5zb248L2I+PGJyPkRhdGENClNwZWNpYWxp c3Q8YnI+PGJyPlRvIG9wdC1vdXQgcmVzcG9uc2Ug4oCYUmVtb3Zl4oCZIGluIHRoZQ0Kc3ViamVj dA0KbGluZS48L3NwYW4+PC9wPjwvZGl2PjwvZGl2PjwvZGl2PjwvZGl2PjwvZGl2PjwvZGl2Pjwv ZGl2Pg0KPHA+Jm5ic3A7PC9wPjxhIHN0eWxlPSdkaXNwbGF5OiBibG9jazsgbWFyZ2luOiAzMnB4 IDAgNDBweCAwOyBwYWRkaW5nOiAgDQoxMHB4OyBmb250LXNpemU6IDFlbTsgdGV4dC1hbGlnbjog Y2VudGVyOyBib3JkZXI6IDA7IGJvcmRlci10b3A6IDFweCBzb2xpZCAgDQpncmF5OyAnIGhyZWY9 J2h0dHBzOi8vZ29vLmdsLzJrc2RSdic+cG93ZXJlZCBieSBHU00uIEZyZWUgbWFpbCBtZXJnZSBh bmQgIA0KZW1haWwgbWFya2V0aW5nIHNvZnR3YXJlIGZvciBHbWFpbC48L2E+DQo= From owner-freebsd-bugs@freebsd.org Wed May 10 19:42:29 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57BB4D5B4CB for ; Wed, 10 May 2017 19:42:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2EC651A79 for ; Wed, 10 May 2017 19:42:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4AJgTZE020165 for ; Wed, 10 May 2017 19:42:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 218968] [patch] [libalias] unbreak translation of transit PPtP/GRE for "nat global" case Date: Wed, 10 May 2017 19:42:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 19:42:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218968 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: eugen Date: Wed May 10 19:41:53 UTC 2017 New revision: 318150 URL: https://svnweb.freebsd.org/changeset/base/318150 Log: ipfw nat and natd support multiple aliasing instances with "nat global" feature that chooses right alias_address for outgoing packets that already have corresponding state in one of aliasing instances. This feature works just fine for ICMP, UDP, TCP and SCTP packes but not for others. For example, outgoing PPtP/GRE packets always get alias_address of latest configured instance no matter whether such packets have corresponding state or not. This change unbreaks translation of transit PPtP/GRE connections for "nat global" case fixing a bug in static ProtoAliasOut() function that ignores its "create" argument and performs translation regardless of its value. This static function is called only by LibAliasOutLocked() function and only for packers other than ICMP, UDP, TCP and SCTP. LibAliasOutLocked() passes its "create" argument unmodified. We have only two consumers of LibAliasOutLocked() in the source tree calling it with "create" unequal to 1: "ipfw nat global" code and similar natd code having same problem. All other consumers of LibAliasOutLocked() call it with create =3D 1 and the patch is "no-op" for such cases. PR: 218968 Approved by: ae, vsevolod (mentor) MFC after: 1 week Changes: head/sys/netinet/libalias/alias.c --=20 You are receiving this mail because: You are the assignee for the bug.=