From owner-freebsd-bugs  Fri Jan 18 11:20:12 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A355F37B420
	for <freebsd-bugs@hub.freebsd.org>; Fri, 18 Jan 2002 11:20:00 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g0IJK0804035;
	Fri, 18 Jan 2002 11:20:00 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 285CD37B405
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Jan 2002 11:11:14 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g0IJBEm01669;
	Fri, 18 Jan 2002 11:11:14 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200201181911.g0IJBEm01669@freefall.freebsd.org>
Date: Fri, 18 Jan 2002 11:11:14 -0800 (PST)
From: Mike Abbott <mike.abbott@cacheflow.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: misc/34043: libfetch FTP upload is broken
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         34043
>Category:       misc
>Synopsis:       libfetch FTP upload is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 18 11:20:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Mike Abbott
>Release:        
>Organization:
CacheFlow, Inc.
>Environment:
>Description:
Revision 1.72 to src/lib/libfetch/ftp.c broke FTP upload.
_ftp_request() always passes O_RDONLY to _ftp_transfer() as the mode
even with STOR or APPE requests.  This causes _ftp_writefn() to fail
because io->dir == O_RDONLY.  In revision 1.71 the mode was
O_WRONLY for STOR and APPE and O_RDONLY for everything else.
>How-To-Repeat:

>Fix:
Make _ftp_request() pass mode O_WRONLY for STOR and APPE and O_RDONLY
for all other requests.
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message