Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Apr 2015 22:39:16 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Lars Engels <lme@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, shadowbq@gmail.com, Baptiste Daroussin <bapt@freebsd.org>
Subject:   Re: svn commit: r384872 - in head/security: . passivedns passivedns/files
Message-ID:  <iocg-dm2z-wny@FreeBSD.org>
References:  <201504272033.t3RKXcGl079169@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain

Lars Engels <lme@FreeBSD.org> writes:

> +USES=		autoreconf gmake libtool
> +AUTOMAKE_ARGS=	--add-missing

AUTOMAKE_ARGS is for USE_AUTOTOOLS, unused by USES=autoreconf.

> +CONFIGURE_ARGS=	--with-ldns-libraries=${PREFIX}/lib
> +CONFIGURE_ARGS+=--with-ldns-includes=${PREFIX}/include

This would break if LOCALBASE != PREFIX. LOCALBASE is a place where
files are installed by *other* ports e.g., dependencies.

  $ poudriere testport -P ...
  [...]
  checking ldns/ldns.h usability... no
  checking ldns/ldns.h presence... no
  checking for ldns/ldns.h... no

    ERROR! ldns headers not found

  ===>  Script "configure" failed unexpectedly.

> +.include <bsd.port.options.mk>

Why? I don't see an option handling or any conditional after the line.

> +++ head/security/passivedns/pkg-descr	Mon Apr 27 20:33:38 2015	(r384872)
[...]
> +(c)2011-2012  -  Edward Bjarte Fjellskal

Defining author in pkg-descr is deprecated. r284239 standardized on the
format but recently bapt@ nuked all such lines. Maybe he can provide
more details or write a CHANGES entry.

https://svnweb.freebsd.org/changeset/ports/284239
https://svnweb.freebsd.org/changeset/ports/380309 (and the like)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQF8BAEBCgBmBQJVP+/0XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bX20H/R0/lciopivWrUws5tpAtUhF
FI94HUqgJqnx7r98/e4MJQCQ8y/Ev/9b/fRu28+1eV8xg0lj1yt8fxNqLLofNka2
6F3YBgptX17pq14sqIl01qTXvkQ3JHGD8OvnrQdSOYyOO+QI1bSELZKdu55J+pGy
6F6yrcrRpTkxwSJVwEAY15Rm8ScHAfgkCxWSfHEhW+bMb+I+A15a+FT26sH0Od4i
fF5kCY7+q1OlufjQ16J6WWGZFXT8yFC1cIp/DmoHaQ5O93jyfUpI/PYGDBY7WMgX
ZPy/oQU0cAkR//VXSHqlDRoWtOx517rDopM18s86qotVcvDcxYohIhfiR4nzb/E=
=PQW3
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?iocg-dm2z-wny>