Date: Wed, 11 May 2016 17:06:03 +0000 (UTC) From: "Conrad E. Meyer" <cem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r299466 - head/contrib/bsnmp/snmpd Message-ID: <201605111706.u4BH63pq039928@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cem Date: Wed May 11 17:06:03 2016 New Revision: 299466 URL: https://svnweb.freebsd.org/changeset/base/299466 Log: bsnmpd: Fix size of trapsink::comm to match other community arrays This fixes a number of possible strcpy() buffer overruns between the various community strings in trap.c. Reported by: Coverity CIDs: 1006820, 1006821, 1006822 Sponsored by: EMC / Isilon Storage Division Modified: head/contrib/bsnmp/snmpd/snmpd.h Modified: head/contrib/bsnmp/snmpd/snmpd.h ============================================================================== --- head/contrib/bsnmp/snmpd/snmpd.h Wed May 11 16:54:34 2016 (r299465) +++ head/contrib/bsnmp/snmpd/snmpd.h Wed May 11 17:06:03 2016 (r299466) @@ -307,7 +307,7 @@ struct trapsink { struct asn_oid index; u_int status; int socket; - u_char comm[SNMP_COMMUNITY_MAXLEN]; + u_char comm[SNMP_COMMUNITY_MAXLEN + 1]; int version; }; enum {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605111706.u4BH63pq039928>