Date: Tue, 11 Jun 2013 19:00:27 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <20130611170026.GE35160@ithaqua.etoilebsd.net> In-Reply-To: <CAF6rxgnt%2BvpD_zFVbe5GwcwZB5_gsB67SkwN5_2Xw7dPkkNVJw@mail.gmail.com> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> <CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A@mail.gmail.com> <20130611164037.GD35160@ithaqua.etoilebsd.net> <CAF6rxgnt%2BvpD_zFVbe5GwcwZB5_gsB67SkwN5_2Xw7dPkkNVJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/T5/D81aE6hAEKcd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2013 at 06:48:34PM +0200, Eitan Adler wrote: > On Tue, Jun 11, 2013 at 6:40 PM, Baptiste Daroussin <bapt@freebsd.org> wr= ote: > > No patching is better, has I'm heavily working with upstream on this po= rt. > > > > In general disable warning is something I don't like, I prefer to fix t= hem, and > > I don't find that complexify the port at all. >=20 > I've found patching software often leads to introducing subtle bugs: > its incredibly annoying trying to track down a bug only to determine > that is is a distro patch. Also, it makes it more difficult for the > reader of the patch to figure out why the patch is there: > it increases the mental effort before "oh, maintainer is just working > around compiler warnings" >=20 > That said, this isn't a strong feeling. I know exactly what I'm doing and why, I know why I do patch, and I'm worki= ng as said in the previous mail directly with upstream (those patches are now integrated in better vesions). I think I have enough experience in the ports tree to decide if I should pa= tch or not my own ports. bapt, --/T5/D81aE6hAEKcd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG3V6oACgkQ8kTtMUmk6EzqXACgvr5LbhNfX+os7/6kypBSCGih 1GEAn2F7TEGjKb8CZ3iUbjevqDT6yAWD =rafH -----END PGP SIGNATURE----- --/T5/D81aE6hAEKcd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130611170026.GE35160>