Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Oct 2021 06:11:19 GMT
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a7c75ee92b0e - stable/12 - ficl: instead of pad, emit can use local variable
Message-ID:  <202110080611.1986BJcY007895@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=a7c75ee92b0edb8ab591f68fe2038de3b68fc031

commit a7c75ee92b0edb8ab591f68fe2038de3b68fc031
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2020-12-01 22:28:02 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2021-10-08 05:24:28 +0000

    ficl: instead of pad, emit can use local variable
    
    Pad in forth is used as "scratchpad" and internal implementations
    should not use it. Ficl does not really follow this rule and this can fire back.
    emit has no need to use pad, we can use local variable instead.
    
    (cherry picked from commit dba7640e44c5ec148a84b0d58c6c9a3c9e5147f3)
---
 stand/ficl/words.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stand/ficl/words.c b/stand/ficl/words.c
index 54257275d5cc..3f781c6d2ff4 100644
--- a/stand/ficl/words.c
+++ b/stand/ficl/words.c
@@ -1015,7 +1015,7 @@ static void twoSwap(FICL_VM *pVM)
 
 static void emit(FICL_VM *pVM)
 {
-    char *cp = pVM->pad;
+    char cp[2];
     int i;
 
 #if FICL_ROBUST > 1



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202110080611.1986BJcY007895>