From owner-svn-src-head@freebsd.org Sat Aug 24 18:48:07 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87981C6F1D; Sat, 24 Aug 2019 18:48:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46G6j16FlYz40N8; Sat, 24 Aug 2019 18:48:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f50.google.com with SMTP id x4so27724879iog.13; Sat, 24 Aug 2019 11:48:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=gEaEQQFDg8fw+igFGufqpJQTuIvryn+/S9XTO8Pmhjg=; b=cHRvTSJUrK9ygK3sKvwjLIjd/arJD0d6BrfaH62TKnC7QKXimMj4L3DxVcfpZgWdRD pf9pkpGjMcbOONqiC1Gzs21vmF5o7bvnguDq00vPn1Ygv6VMRyiUz31lpb03jzMX842R mdWudqyI3awPu1/n0devE2ccbADwDmTgR3MFjbpnX1DkXkKSk0uUol8O3+rF4bk5pMbc wh8k0WosL3G7vdAmSmC1DD2njCpwj+R0mAxREIK344IEcqrQA+HGlp06gh2NcYeiiHS3 IrDPHHs971Qk3p76MDydtDH0iIrrhw1egr67xHG0O49g70XeP9tVKzVNJ86AqqYzz4br 53ng== X-Gm-Message-State: APjAAAUji4rUHzH9VQMygCap5vcc5klV0X/NpAPLttgYhkuBrWmoMVvU WFPA/wmMqQxxF25rEDcWP8am9E06 X-Google-Smtp-Source: APXvYqzmQzAm7caKERZSNhT8LOI1Cg+2mx0ImkzSivS+LTcCKc2L4QUEV6/hypF4K+U3co3i8vwpWw== X-Received: by 2002:a5d:8484:: with SMTP id t4mr14100586iom.5.1566672484222; Sat, 24 Aug 2019 11:48:04 -0700 (PDT) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com. [209.85.166.51]) by smtp.gmail.com with ESMTPSA id c11sm10062377ioq.63.2019.08.24.11.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2019 11:48:03 -0700 (PDT) Received: by mail-io1-f51.google.com with SMTP id 18so27798955ioe.10; Sat, 24 Aug 2019 11:48:03 -0700 (PDT) X-Received: by 2002:a5e:a80f:: with SMTP id c15mr10057618ioa.270.1566672483659; Sat, 24 Aug 2019 11:48:03 -0700 (PDT) MIME-Version: 1.0 References: <201908241528.x7OFSemm026182@repo.freebsd.org> <20190824161503.GA71821@kib.kiev.ua> In-Reply-To: <20190824161503.GA71821@kib.kiev.ua> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 24 Aug 2019 11:47:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351456 - head/sys/amd64/amd64 To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46G6j16FlYz40N8 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.61 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[50.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.62)[ip: (-7.35), ipnet: 209.85.128.0/17(-3.35), asn: 15169(-2.34), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2019 18:48:07 -0000 On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov wrote: > > On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer wrote: > > Hi Konstantin, > > > > What is the motivation for this change? The commit message doesn't > > really describe why it was done. > > Really it does. There is no point to request allocations for e.g. > doublefault stack to be at the local domain, because this stack is only > used once. Doublefault is definitely a machine halt situation, it does > not matter if it generates inter-socket traffic to handle. > > Same for boot stacks, and for mce. > > The change avoids unnecessary constraints. Sure, but what is the harm of the unnecessary constraints? Does this change fix an actual bug, or is it just a stylistic preference to avoid domain-specific allocations for infrequently used objects? Thanks, Conrad